[gnome-shell/wip/smartcard: 3/16] authPrompt: don't muck with cancelButton in onAskQuestion



commit 82613ba5df1ac4174f0c516f7154d3fdee2cebe1
Author: Ray Strode <rstrode redhat com>
Date:   Sun Jul 28 16:15:43 2013 -0400

    authPrompt: don't muck with cancelButton in onAskQuestion
    
    onAskQuestion has this code:
    
        if (this.verifyingUser)
            this.cancelButton.show();
        else
            this.cancelButton.hide();
    
    but onAskQuestion can only be called when this.verifyingUser is true.
    Also, cancelButton is public, and it only ever otherwise gets hidden
    from callers.
    
    This commit drops mucking with cancelButton visibility, leaving it
    entirely up to the callers to deal with.

 js/gdm/authPrompt.js |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/js/gdm/authPrompt.js b/js/gdm/authPrompt.js
index 6b2480b..f287b9e 100644
--- a/js/gdm/authPrompt.js
+++ b/js/gdm/authPrompt.js
@@ -195,11 +195,6 @@ const AuthPrompt = new Lang.Class({
         this.setPasswordChar(passwordChar);
         this.setQuestion(question);
 
-        if (this.verifyingUser)
-            this.cancelButton.show();
-        else
-            this.cancelButton.hide();
-
         if (passwordChar) {
             if (this._userVerifier.reauthenticating)
                 this.nextButton.label = _("Unlock");


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]