[gnome-shell] overview: Don't allow exiting the overview if we have a DND drag
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] overview: Don't allow exiting the overview if we have a DND drag
- Date: Sun, 12 May 2013 18:40:14 +0000 (UTC)
commit b689972e6779cf026d2d05172aa10c63b8a35608
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Wed Mar 27 13:31:43 2013 -0400
overview: Don't allow exiting the overview if we have a DND drag
Otherwise, people can drag app icons or window thumbnails out of
the overview, and it just looks weird.
https://bugzilla.gnome.org/show_bug.cgi?id=698484
js/ui/overview.js | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
---
diff --git a/js/ui/overview.js b/js/ui/overview.js
index c3ae2bb..12785ad 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -435,6 +435,7 @@ const Overview = new Lang.Class({
beginItemDrag: function(source) {
this.emit('item-drag-begin');
+ this._inDrag = true;
},
cancelledItemDrag: function(source) {
@@ -443,10 +444,12 @@ const Overview = new Lang.Class({
endItemDrag: function(source) {
this.emit('item-drag-end');
+ this._inDrag = false;
},
beginWindowDrag: function(source) {
this.emit('window-drag-begin');
+ this._inDrag = true;
},
cancelledWindowDrag: function(source) {
@@ -455,6 +458,7 @@ const Overview = new Lang.Class({
endWindowDrag: function(source) {
this.emit('window-drag-end');
+ this._inDrag = false;
},
// show:
@@ -578,6 +582,8 @@ const Overview = new Lang.Class({
shouldToggleByCornerOrButton: function() {
if (this.animationInProgress)
return false;
+ if (this._inDrag)
+ return false;
if (this._activationTime == 0 || Date.now() / 1000 - this._activationTime >
OVERVIEW_ACTIVATION_TIMEOUT)
return true;
return false;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]