[polari] chatView: Improve URL handling

[Florian Müllner <fmuellner src gnome org>]

commit 2631829e14bc51b391b8cad063c0002a49de828d
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Nov 1 17:03:10 2013 +0100

    chatView: Improve URL handling
    
    Our handling of URL clicks currently interacts badly with GtkTextView's
    text selections. To sanitize the behavior, make sure that:
      - selections cannot be started from within a URL
      - URLs are only activated on full clicks (both PRESS and RELEASE)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=711217

 src/chatView.js |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)
---
diff --git a/src/chatView.js b/src/chatView.js
index b662e9f..aede63b 100644
--- a/src/chatView.js
+++ b/src/chatView.js
@@ -222,6 +222,8 @@ const ChatView = new Lang.Class({
                                  Lang.bind(this, this._updateScroll));
         this._view.connect('button-release-event',
                            Lang.bind(this, this._handleLinkClicks));
+        this._view.connect('button-press-event',
+                           Lang.bind(this, this._handleLinkClicks));
         this._view.connect('motion-notify-event',
                            Lang.bind(this, this._handleLinkHovers));
     },
@@ -295,6 +297,11 @@ const ChatView = new Lang.Class({
         if (button != Gdk.BUTTON_PRIMARY)
             return false;
 
+        let isPress = event.get_event_type() == Gdk.EventType.BUTTON_PRESS;
+
+        if (isPress)
+            this._clickedUrl = null;
+
         let [, eventX, eventY] = event.get_coords();
         let [x, y] = view.window_to_buffer_coords(Gtk.TextWindowType.WIDGET,
                                                   eventX, eventY);
@@ -304,9 +311,15 @@ const ChatView = new Lang.Class({
         for (let i = 0; i < tags.length; i++) {
             let url = tags[i]._url;
             if (url) {
-                if (url.indexOf(':') == -1)
-                    url = 'http://' + url;
-                Gio.AppInfo.launch_default_for_uri(url, null);
+                if (isPress) {
+                    this._clickedUrl = url;
+                    return true;
+                } else if (this._clickedUrl == url) {
+                    if (url.indexOf(':') == -1)
+                        url = 'http://' + url;
+                    Gio.AppInfo.launch_default_for_uri(url, null);
+                    return true;
+                }
                 break;
             }
         }