[glom] FoundSet: Remove unused broken operator=().
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glom] FoundSet: Remove unused broken operator=().
- Date: Fri, 15 Nov 2013 20:30:24 +0000 (UTC)
commit ad76bff06cfd4d68c9ebf18ba1f1270ca0afccd6
Author: Murray Cumming <murrayc murrayc com>
Date: Tue Nov 5 21:11:50 2013 +0100
FoundSet: Remove unused broken operator=().
glom/libglom/data_structure/foundset.cc | 8 --------
glom/libglom/data_structure/foundset.h | 4 ++++
2 files changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/glom/libglom/data_structure/foundset.cc b/glom/libglom/data_structure/foundset.cc
index 0412d7f..031fa6b 100644
--- a/glom/libglom/data_structure/foundset.cc
+++ b/glom/libglom/data_structure/foundset.cc
@@ -45,12 +45,4 @@ FoundSet& FoundSet::operator=(const FoundSet& src)
return *this;
}
-bool FoundSet::operator==(const FoundSet& src) const
-{
- return (m_table_name == src.m_table_name)
- && (m_extra_join == src.m_extra_join)
- /* TODO: && (m_where_clause == src.m_where_clause) */
- && (m_sort_clause == src.m_sort_clause);
-}
-
} //namespace Glom
diff --git a/glom/libglom/data_structure/foundset.h b/glom/libglom/data_structure/foundset.h
index e2b3f62..e3949af 100644
--- a/glom/libglom/data_structure/foundset.h
+++ b/glom/libglom/data_structure/foundset.h
@@ -41,8 +41,12 @@ public:
FoundSet(const FoundSet& src);
FoundSet& operator=(const FoundSet& src);
+private:
+ //We cannot implement this without a way to compare GdaSqlExpr instances,
+ //but luckily we don't need to compare FoundSet instances anyway.
bool operator==(const FoundSet& src) const;
+public:
Glib::ustring m_table_name;
sharedptr<const Relationship> m_extra_join; // Only used for doubly-related related records (portals), in
which case the WHERE clause is also slightly different.
Gnome::Gda::SqlExpr m_where_clause;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]