[glom] Remove some now-irrelevant TODO comments.



commit e1ced4d61002c73f0c15f8ec6afcc8f8c1f9cfcf
Author: Murray Cumming <murrayc murrayc com>
Date:   Tue Nov 19 11:44:15 2013 +0100

    Remove some now-irrelevant TODO comments.

 glom/libglom/db_utils.h                            |    3 ---
 glom/libglom/python_embed/py_glom_relatedrecord.cc |    2 --
 tests/test_document_load_translations.cc           |    2 +-
 3 files changed, 1 insertions(+), 6 deletions(-)
---
diff --git a/glom/libglom/db_utils.h b/glom/libglom/db_utils.h
index 47d241c..f4646e0 100644
--- a/glom/libglom/db_utils.h
+++ b/glom/libglom/db_utils.h
@@ -147,9 +147,6 @@ void remove_auto_increment(const Glib::ustring& table_name, const Glib::ustring&
 void layout_item_fill_field_details(const Document* document, const Glib::ustring& parent_table_name, 
sharedptr<LayoutItem_Field>& layout_item);
 
 
-//TODO: It would be nice to use sharedptr<const Relationship>& instead of sharedptr<Relationship>&,
-//but it does not seem possible to pass a sharedptr<const Relationship> for a sharedptr<const Relationship>&.
-
 /** Decides whether a field should have an Open button next to it,
  * allowing the user to navigate to a related record.
  *
diff --git a/glom/libglom/python_embed/py_glom_relatedrecord.cc 
b/glom/libglom/python_embed/py_glom_relatedrecord.cc
index 1843d02..ecae130 100644
--- a/glom/libglom/python_embed/py_glom_relatedrecord.cc
+++ b/glom/libglom/python_embed/py_glom_relatedrecord.cc
@@ -68,7 +68,6 @@ boost::python::object PyGlomRelatedRecord::getitem(const boost::python::object&
   const Glib::ustring related_table = m_relationship->get_to_table();
 
   //Check whether the field exists in the table.
-  //TODO_Performance: Do this without the useless Field information?
   sharedptr<const Field> field = m_document->get_field(m_relationship->get_to_table(), field_name);
   if(!field)
   {
@@ -155,7 +154,6 @@ boost::python::object PyGlomRelatedRecord::generic_aggregate(const std::string&
   const Glib::ustring related_table = m_relationship->get_to_table();
 
   //Check whether the field exists in the table.
-  //TODO_Performance: Do this without the useless Field information?
   sharedptr<Field> field = m_document->get_field(m_relationship->get_to_table(), field_name);
   if(!field)
   {
diff --git a/tests/test_document_load_translations.cc b/tests/test_document_load_translations.cc
index 955c109..4e1e0da 100644
--- a/tests/test_document_load_translations.cc
+++ b/tests/test_document_load_translations.cc
@@ -252,7 +252,7 @@ int main()
   g_assert( document.get_table_title_singular_original("scenes") == "Scene" );
   
   g_assert( document.get_table_title("scenes", locale_de) == "Szenen" );
-  g_assert( document.get_table_title_singular("scenes", locale_de) == "Szene" ); //TODO: Make sure this is 
translated correctly.
+  g_assert( document.get_table_title_singular("scenes", locale_de) == "Szene" );
 
   //Check a field:
   Glom::sharedptr<const Glom::Field> field = document.get_field("contacts", "contact_id");


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]