[gnome-software/gnome-3-10] plugin-appstream: Return FALSE if we set GError



commit c5c72193825cd15c04059c3c116303857d7f7704
Author: Colin Walters <walters verbum org>
Date:   Sun Nov 3 19:22:06 2013 -0500

    plugin-appstream: Return FALSE if we set GError
    
    Side note: an OSTree-like rigorous coding style where ret = FALSE
    always at the start of a function would make this error setting errors
    not happen.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=711368

 src/plugins/gs-plugin-appstream.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/plugins/gs-plugin-appstream.c b/src/plugins/gs-plugin-appstream.c
index 31e6740..c2ec00e 100644
--- a/src/plugins/gs-plugin-appstream.c
+++ b/src/plugins/gs-plugin-appstream.c
@@ -264,6 +264,7 @@ gs_plugin_startup (GsPlugin *plugin, GError **error)
        size = appstream_cache_get_size (plugin->priv->cache);
        if (size == 0) {
                g_warning ("No AppStream data, try 'make install-sample-data' in data/");
+               ret = FALSE;
                g_set_error (error,
                             GS_PLUGIN_LOADER_ERROR,
                             GS_PLUGIN_LOADER_ERROR_FAILED,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]