[gtk+/gtk-3-10] defaultvalue test: ignore show-desktop
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/gtk-3-10] defaultvalue test: ignore show-desktop
- Date: Tue, 26 Nov 2013 21:06:03 +0000 (UTC)
commit 8882c6408bad7e3c5a3180bd0aa5f1fc8933bd05
Author: Ryan Lortie <desrt desrt ca>
Date: Fri Nov 15 09:32:19 2013 -0500
defaultvalue test: ignore show-desktop
Ignore the "show-desktop" property on GtkPlacesSidebar for the
defaultvalue test.
Currently, "make check" is passing because it runs the test under a xvfb
with no XSETTINGS provider, so we see the Gtk default value. No matter
what we set the default value to in Gtk, however, there will be some
desktop environment in which someone running the installed test outside
of an xvfb will get the wrong result. Best to ignore it.
https://bugzilla.gnome.org/show_bug.cgi?id=712302
testsuite/gtk/defaultvalue.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/testsuite/gtk/defaultvalue.c b/testsuite/gtk/defaultvalue.c
index 1d9c2af..bdb0bb6 100644
--- a/testsuite/gtk/defaultvalue.c
+++ b/testsuite/gtk/defaultvalue.c
@@ -320,6 +320,11 @@ G_GNUC_END_IGNORE_DEPRECATIONS
strcmp (pspec->name, "resize-grip-visible") == 0)
continue;
+ /* show-desktop depends on desktop environment */
+ if (g_type_is_a (type, GTK_TYPE_PLACES_SIDEBAR) &&
+ strcmp (pspec->name, "show-desktop") == 0)
+ continue;
+
if (g_test_verbose ())
g_print ("Property %s.%s\n",
g_type_name (pspec->owner_type),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]