[libgsystem] gs_file_read_noatime: Always return errors
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgsystem] gs_file_read_noatime: Always return errors
- Date: Thu, 5 Sep 2013 16:47:53 +0000 (UTC)
commit 870b672bb28e4c8cf4ba86075ba24b4dd5b85f42
Author: Bastien Nocera <hadess hadess net>
Date: Sat Aug 24 05:38:31 2013 +0200
gs_file_read_noatime: Always return errors
When passed an invalid GFile, or one that's not FUSE backed,
we should error out properly instead of not returning an error.
https://bugzilla.gnome.org/show_bug.cgi?id=699252
gsystem-file-utils.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/gsystem-file-utils.c b/gsystem-file-utils.c
index babae9d..f70239c 100644
--- a/gsystem-file-utils.c
+++ b/gsystem-file-utils.c
@@ -118,7 +118,14 @@ gs_file_read_noatime (GFile *file,
path = gs_file_get_path_cached (file);
if (path == NULL)
- return NULL;
+ {
+ char *uri;
+ uri = g_file_get_uri (file);
+ g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_NOENT,
+ "%s has no associated path", uri);
+ g_free (uri);
+ return NULL;
+ }
fd = _open_fd_noatime (path);
if (fd < 0)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]