[geary] Unable to authenticate SMTP credentials: Closes bgo#721570

[Jim Nelson <jnelson src gnome org>]

commit 3ba75dac2ad8cf2d8fb25a2daeb5f06961247384
Author: Jim Nelson <jim yorba org>
Date:   Mon Jan 20 11:23:16 2014 -0800

    Unable to authenticate SMTP credentials: Closes bgo#721570
    
    User's server was returning a status code that indicates an invalid
    password, when in fact it was simply indicating that it didn't
    support the AUTH type (even though it advertised it in its connect
    capabilities).  This removes the error-checking by SMTP value and
    simply attempts all chosed AUTH types.

 src/engine/smtp/smtp-client-session.vala |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/src/engine/smtp/smtp-client-session.vala b/src/engine/smtp/smtp-client-session.vala
index c4144a6..573b844 100644
--- a/src/engine/smtp/smtp-client-session.vala
+++ b/src/engine/smtp/smtp-client-session.vala
@@ -104,11 +104,6 @@ public class Geary.Smtp.ClientSession {
             Response response = yield cx.authenticate_async(authenticator, cancellable);
             if (response.code.is_success_completed())
                 return authenticator;
-            
-            // syntax errors indicate the command was unknown or unimplemented, i.e. unavailable
-            // authentication type, so try again, otherwise treat as authentication failure
-            if (!response.code.is_syntax_error())
-                break;
         } while (auth_order.size > 0);
         
         throw new SmtpError.AUTHENTICATION_FAILED("Unable to authenticate with %s", to_string());