[gedit/wip/loader-saver: 26/58] GeditDocument: remove all paramaters of the "load" and "save" signals
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gedit/wip/loader-saver: 26/58] GeditDocument: remove all paramaters of the "load" and "save" signals
- Date: Sun, 6 Jul 2014 16:41:48 +0000 (UTC)
commit 2730bae880d4d139909c0bee6665fbe0e0d0b126
Author: Sébastien Wilmet <swilmet gnome org>
Date: Thu Jun 26 21:51:57 2014 +0200
GeditDocument: remove all paramaters of the "load" and "save" signals
They are no longer useful. A plugin just wants to know when a file
loading or saving starts and ends. gedit takes care of the parameters.
The signal marshaller is set to NULL to use the generic marshaller.
gedit/gedit-document.c | 40 ++++++----------------------------------
gedit/gedit-document.h | 32 +++++++++++---------------------
2 files changed, 17 insertions(+), 55 deletions(-)
---
diff --git a/gedit/gedit-document.c b/gedit/gedit-document.c
index 28999da..5180ba4 100644
--- a/gedit/gedit-document.c
+++ b/gedit/gedit-document.c
@@ -542,13 +542,8 @@ gedit_document_class_init (GeditDocumentClass *klass)
/**
* GeditDocument::load:
* @document: the #GeditDocument.
- * @location: the location where to load the document from.
- * @encoding: the #GeditEncoding to encode the document.
- * @line_pos: the line to show.
- * @column_pos: the column to show.
- * @create: whether the document should be created if it doesn't exist.
*
- * The "load" signal is emitted when a document is loaded.
+ * The "load" signal is emitted at the beginning of a file loading.
*
* Since: 2.22
*/
@@ -557,17 +552,8 @@ gedit_document_class_init (GeditDocumentClass *klass)
G_OBJECT_CLASS_TYPE (object_class),
G_SIGNAL_RUN_LAST,
G_STRUCT_OFFSET (GeditDocumentClass, load),
- NULL, NULL,
- gedit_marshal_VOID__OBJECT_BOXED_INT_BOOLEAN,
- G_TYPE_NONE,
- 4,
- G_TYPE_FILE,
- /* we rely on the fact that the GeditEncoding pointer stays
- * the same forever */
- GEDIT_TYPE_ENCODING | G_SIGNAL_TYPE_STATIC_SCOPE,
- G_TYPE_INT,
- G_TYPE_INT,
- G_TYPE_BOOLEAN);
+ NULL, NULL, NULL,
+ G_TYPE_NONE, 0);
document_signals[LOADED] =
g_signal_new ("loaded",
@@ -583,13 +569,8 @@ gedit_document_class_init (GeditDocumentClass *klass)
/**
* GeditDocument::save:
* @document: the #GeditDocument.
- * @location: the location where the document is about to be saved.
- * @encoding: the #GeditEncoding used to save the document.
- * @newline_type: the #GeditDocumentNewlineType used to save the document.
- * @compression_type: the #GtkSourceCompressionType used to save the document.
- * @flags: the #GeditDocumentSaveFlags for the save operation.
*
- * The "save" signal is emitted when the document is saved.
+ * The "save" signal is emitted at the beginning of a file saving.
*
* Since: 2.20
*/
@@ -598,17 +579,8 @@ gedit_document_class_init (GeditDocumentClass *klass)
G_OBJECT_CLASS_TYPE (object_class),
G_SIGNAL_RUN_LAST,
G_STRUCT_OFFSET (GeditDocumentClass, save),
- NULL, NULL,
- gedit_marshal_VOID__OBJECT_BOXED_ENUM_ENUM_FLAGS,
- G_TYPE_NONE,
- 5,
- G_TYPE_FILE,
- /* we rely on the fact that the GeditEncoding pointer stays
- * the same forever */
- GEDIT_TYPE_ENCODING | G_SIGNAL_TYPE_STATIC_SCOPE,
- GEDIT_TYPE_DOCUMENT_NEWLINE_TYPE,
- GTK_SOURCE_TYPE_COMPRESSION_TYPE,
- GEDIT_TYPE_DOCUMENT_SAVE_FLAGS);
+ NULL, NULL, NULL,
+ G_TYPE_NONE, 0);
document_signals[SAVED] =
g_signal_new ("saved",
diff --git a/gedit/gedit-document.h b/gedit/gedit-document.h
index ee0eaaf..afe88dd 100644
--- a/gedit/gedit-document.h
+++ b/gedit/gedit-document.h
@@ -92,27 +92,17 @@ struct _GeditDocumentClass
/* Signals */
- void (* cursor_moved) (GeditDocument *document);
-
- void (* load) (GeditDocument *doc,
- GFile *location,
- const GeditEncoding *encoding,
- gint line_pos,
- gint column_pos,
- gboolean create);
-
- void (* loaded) (GeditDocument *document,
- const GError *error);
-
- void (* save) (GeditDocument *document,
- GFile *location,
- const GeditEncoding *encoding,
- GeditDocumentNewlineType newline_type,
- GtkSourceCompressionType compression_type,
- GeditDocumentSaveFlags flags);
-
- void (* saved) (GeditDocument *document,
- const GError *error);
+ void (* cursor_moved) (GeditDocument *document);
+
+ void (* load) (GeditDocument *document);
+
+ void (* loaded) (GeditDocument *document,
+ const GError *error);
+
+ void (* save) (GeditDocument *document);
+
+ void (* saved) (GeditDocument *document,
+ const GError *error);
};
#define GEDIT_DOCUMENT_ERROR gedit_document_error_quark ()
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]