[gitg] Lazily construct diff options
- From: Jesse van den Kieboom <jessevdk src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gitg] Lazily construct diff options
- Date: Thu, 10 Jul 2014 14:54:24 +0000 (UTC)
commit 94f138e1bc46af9d813b8a058d5be591cb5a6020
Author: Jesse van den Kieboom <jessevdk gnome org>
Date: Thu Jul 10 16:53:55 2014 +0200
Lazily construct diff options
libgitg/gitg-diff-view.vala | 16 +++++++++++-----
1 files changed, 11 insertions(+), 5 deletions(-)
---
diff --git a/libgitg/gitg-diff-view.vala b/libgitg/gitg-diff-view.vala
index 45b642f..9ea2ec0 100644
--- a/libgitg/gitg-diff-view.vala
+++ b/libgitg/gitg-diff-view.vala
@@ -52,7 +52,7 @@ namespace Gitg
private Commit? d_commit;
private Settings? d_fontsettings;
private bool d_has_selection;
- private Ggit.DiffOptions d_options;
+ private Ggit.DiffOptions? d_options;
private static Gee.HashMap<string, DiffView> s_diff_map;
private static uint64 s_diff_id;
@@ -62,7 +62,15 @@ namespace Gitg
public Ggit.DiffOptions options
{
- get { return d_options; }
+ get
+ {
+ if (d_options == null)
+ {
+ d_options = new Ggit.DiffOptions();
+ }
+
+ return d_options;
+ }
}
[Notify]
@@ -388,8 +396,6 @@ namespace Gitg
{
base.constructed();
- d_options = new Ggit.DiffOptions();
-
var settings = new WebKit.Settings();
var dbg = Environment.get_variable("GITG_GTK_DIFF_VIEW_DEBUG") != null;
@@ -475,7 +481,7 @@ namespace Gitg
if (d_commit != null)
{
- d_diff = d_commit.get_diff(d_options);
+ d_diff = d_commit.get_diff(options);
}
if (d_diff != null)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]