[evolution] Crash in client_selector_allow_auth_prompt_done_cb() on error
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution] Crash in client_selector_allow_auth_prompt_done_cb() on error
- Date: Tue, 17 Jun 2014 13:54:25 +0000 (UTC)
commit 17cef3b8c8862f0659f287763c94ed6a6077a00c
Author: Milan Crha <mcrha redhat com>
Date: Tue Jun 17 15:52:30 2014 +0200
Crash in client_selector_allow_auth_prompt_done_cb() on error
Actually, g_simple_async_result_take_error() means take, not copy,
thus the later g_clear_error() was incorrect, possibly freeing
already freed memory.
e-util/e-client-selector.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/e-util/e-client-selector.c b/e-util/e-client-selector.c
index 740d456..9951ae3 100644
--- a/e-util/e-client-selector.c
+++ b/e-util/e-client-selector.c
@@ -629,8 +629,7 @@ client_selector_allow_auth_prompt_done_cb (GObject *source_object,
if (local_error) {
g_simple_async_result_take_error (data->simple, local_error);
g_simple_async_result_complete (data->simple);
-
- g_clear_error (&local_error);
+ local_error = NULL;
} else {
EClientCache *client_cache;
const gchar *extension_name;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]