[libgovirt] Fix return value of ovirt_rest_call_finish()
- From: Christophe Fergeau <teuf src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgovirt] Fix return value of ovirt_rest_call_finish()
- Date: Thu, 26 Jun 2014 23:22:40 +0000 (UTC)
commit 1034e93e254cadac191d254b3c892cc3d5077fc0
Author: Christophe Fergeau <cfergeau redhat com>
Date: Wed Jun 25 17:18:30 2014 +0200
Fix return value of ovirt_rest_call_finish()
In some cases (when the caller did not provide an additional callback
to be called on completion of the async operation),
ovirt_rest_call_finish() would return FALSE even though the async call
was successful. This could be hit when using the async version of
ovirt_cdrom_update_async() for example.
govirt/ovirt-proxy.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/govirt/ovirt-proxy.c b/govirt/ovirt-proxy.c
index 8ca78af..4869cc5 100644
--- a/govirt/ovirt-proxy.c
+++ b/govirt/ovirt-proxy.c
@@ -233,7 +233,7 @@ call_async_cb(RestProxyCall *call, const GError *error,
g_simple_async_result_set_from_error(result, error);
} else {
GError *call_error = NULL;
- gboolean callback_result = FALSE;
+ gboolean callback_result = TRUE;
if (data->call_async_cb != NULL) {
callback_result = data->call_async_cb(data->proxy, call,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]