[gtk+] Bring back redundant notifications for GtkToggleButton::draw-indicator
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] Bring back redundant notifications for GtkToggleButton::draw-indicator
- Date: Sat, 28 Jun 2014 01:26:12 +0000 (UTC)
commit 08e5efd60584098d0bd509fcb343cf68077a80ec
Author: Matthias Clasen <mclasen redhat com>
Date: Fri Jun 27 21:22:40 2014 -0400
Bring back redundant notifications for GtkToggleButton::draw-indicator
GtkCheckButton sets a different initial value for this property without
actually changing the declared default, and then relies on change notification
to update other properties (such as xalign). This, combined with glades
insistance on putting default values into ui files creates a situation
where we can't remove the redundant notification for ::draw-indicator
without causing lots of checkboxes to suddenly have centered labels.
This was seen in gnome-terminal, evolution, and other applications.
Therefore, keep the extra notification for now. This can be revisited
when we clean up the button hierarchy.
gtk/gtktogglebutton.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtktogglebutton.c b/gtk/gtktogglebutton.c
index ef5ece5..c73ab85 100644
--- a/gtk/gtktogglebutton.c
+++ b/gtk/gtktogglebutton.c
@@ -202,7 +202,7 @@ gtk_toggle_button_class_init (GtkToggleButtonClass *class)
P_("Draw Indicator"),
P_("If the toggle part of the button is displayed"),
FALSE,
- GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY));
+ GTK_PARAM_READWRITE));
/**
* GtkToggleButton::toggled:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]