[rhythmbox] playbin: fix possible crash in error handling
- From: Jonathan Matthew <jmatthew src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [rhythmbox] playbin: fix possible crash in error handling
- Date: Sat,  8 Mar 2014 09:15:57 +0000 (UTC)
commit 552f3cfa173a71991bd5980f91000ee518240b69
Author: Jonathan Matthew <jonathan d14n org>
Date:   Sat Mar 8 19:14:49 2014 +1000
    playbin: fix possible crash in error handling
    
    gst_message_parse_error won't necessarily return debug information,
    so initialize the pointer used to hold it so we can safely free it
    later.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=707618
 backends/gstreamer/rb-player-gst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/backends/gstreamer/rb-player-gst.c b/backends/gstreamer/rb-player-gst.c
index 1cb7152..ef6f9dd 100644
--- a/backends/gstreamer/rb-player-gst.c
+++ b/backends/gstreamer/rb-player-gst.c
@@ -497,7 +497,7 @@ bus_cb (GstBus *bus, GstMessage *message, RBPlayerGst *mp)
 
        switch (GST_MESSAGE_TYPE (message)) {
        case GST_MESSAGE_ERROR: {
-               char *debug;
+               char *debug = NULL;
                GError *error = NULL;
                GError *sig_error = NULL;
                int code;
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]