[gnome-themes-standard] There were unused hover states for checkboxes and radios in the assets - use them
- From: Jakub Steiner <jimmac src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-themes-standard] There were unused hover states for checkboxes and radios in the assets - use them
- Date: Mon, 5 May 2014 16:31:45 +0000 (UTC)
commit f1b031ffae1976e76a6ba46bb8cb0c7502e0ab81
Author: Nikita Churaev <lamefun x0r gmail com>
Date: Mon May 5 16:32:43 2014 +0400
There were unused hover states for checkboxes and radios in the assets - use them
https://bugzilla.gnome.org/show_bug.cgi?id=729561
themes/Adwaita/gtk-3.0/assets.txt | 12 ++++++
.../assets/checkbox-checked-hover-dark 2 png | Bin 0 -> 1744 bytes
.../gtk-3.0/assets/checkbox-checked-hover 2 png | Bin 0 -> 1962 bytes
.../gtk-3.0/assets/checkbox-mixed-hover-dark 2 png | Bin 0 -> 1019 bytes
.../gtk-3.0/assets/checkbox-mixed-hover 2 png | Bin 0 -> 1112 bytes
.../assets/checkbox-unchecked-hover-dark 2 png | Bin 0 -> 807 bytes
.../gtk-3.0/assets/checkbox-unchecked-hover 2 png | Bin 0 -> 870 bytes
themes/Adwaita/gtk-3.0/gtk-widgets-assets-dark.css | 32 ++++++++++++++++
themes/Adwaita/gtk-3.0/gtk-widgets-assets.css | 38 +++++++++++++++++++-
themes/Adwaita/gtk-3.0/gtk.gresource.xml | 24 ++++++++++++
10 files changed, 105 insertions(+), 1 deletions(-)
---
diff --git a/themes/Adwaita/gtk-3.0/assets.txt b/themes/Adwaita/gtk-3.0/assets.txt
index ca6739a..58219b2 100644
--- a/themes/Adwaita/gtk-3.0/assets.txt
+++ b/themes/Adwaita/gtk-3.0/assets.txt
@@ -1,70 +1,82 @@
checkbox-checked
+checkbox-checked-hover
checkbox-checked-alt
checkbox-checked-insensitive
checkbox-checked-insensitive-alt
checkbox-checked-backdrop
checkbox-checked-backdrop-insensitive
checkbox-unchecked
+checkbox-unchecked-hover
checkbox-unchecked-alt
checkbox-unchecked-insensitive
checkbox-unchecked-insensitive-alt
checkbox-unchecked-backdrop
checkbox-unchecked-backdrop-insensitive
checkbox-mixed
+checkbox-mixed-hover
checkbox-mixed-alt
checkbox-mixed-insensitive
checkbox-mixed-insensitive-alt
checkbox-mixed-backdrop
checkbox-mixed-backdrop-insensitive
radio-checked
+radio-checked-hover
radio-checked-alt
radio-checked-insensitive
radio-checked-insensitive-alt
radio-checked-backdrop
radio-checked-backdrop-insensitive
radio-unchecked
+radio-unchecked-hover
radio-unchecked-alt
radio-unchecked-insensitive
radio-unchecked-insensitive-alt
radio-unchecked-backdrop
radio-unchecked-backdrop-insensitive
radio-mixed
+radio-mixed-hover
radio-mixed-alt
radio-mixed-insensitive
radio-mixed-insensitive-alt
radio-mixed-backdrop
radio-mixed-backdrop-insensitive
checkbox-checked-dark
+checkbox-checked-hover-dark
checkbox-checked-alt-dark
checkbox-checked-insensitive-dark
checkbox-checked-insensitive-alt-dark
checkbox-checked-backdrop-dark
checkbox-checked-backdrop-insensitive-dark
checkbox-unchecked-dark
+checkbox-unchecked-hover-dark
checkbox-unchecked-alt-dark
checkbox-unchecked-insensitive-dark
checkbox-unchecked-insensitive-alt-dark
checkbox-unchecked-backdrop-dark
checkbox-unchecked-backdrop-insensitive-dark
checkbox-mixed-dark
+checkbox-mixed-hover-dark
checkbox-mixed-alt-dark
checkbox-mixed-insensitive-dark
checkbox-mixed-insensitive-alt-dark
checkbox-mixed-backdrop-dark
checkbox-mixed-backdrop-insensitive-dark
radio-checked-dark
+radio-checked-hover-dark
radio-checked-alt-dark
radio-checked-insensitive-dark
radio-checked-insensitive-alt-dark
radio-checked-backdrop-dark
radio-checked-backdrop-insensitive-dark
radio-unchecked-dark
+radio-unchecked-hover-dark
radio-unchecked-alt-dark
radio-unchecked-insensitive-dark
radio-unchecked-insensitive-alt-dark
radio-unchecked-backdrop-dark
radio-unchecked-backdrop-insensitive-dark
radio-mixed-dark
+radio-mixed-hover-dark
radio-mixed-alt-dark
radio-mixed-insensitive-dark
radio-mixed-insensitive-alt-dark
diff --git a/themes/Adwaita/gtk-3.0/assets/checkbox-checked-hover-dark 2 png
b/themes/Adwaita/gtk-3.0/assets/checkbox-checked-hover-dark 2 png
new file mode 100644
index 0000000..120657f
Binary files /dev/null and b/themes/Adwaita/gtk-3.0/assets/checkbox-checked-hover-dark 2 png differ
diff --git a/themes/Adwaita/gtk-3.0/assets/checkbox-checked-hover 2 png
b/themes/Adwaita/gtk-3.0/assets/checkbox-checked-hover 2 png
new file mode 100644
index 0000000..4dd52a1
Binary files /dev/null and b/themes/Adwaita/gtk-3.0/assets/checkbox-checked-hover 2 png differ
diff --git a/themes/Adwaita/gtk-3.0/assets/checkbox-mixed-hover-dark 2 png
b/themes/Adwaita/gtk-3.0/assets/checkbox-mixed-hover-dark 2 png
new file mode 100644
index 0000000..bdcfa9a
Binary files /dev/null and b/themes/Adwaita/gtk-3.0/assets/checkbox-mixed-hover-dark 2 png differ
diff --git a/themes/Adwaita/gtk-3.0/assets/checkbox-mixed-hover 2 png
b/themes/Adwaita/gtk-3.0/assets/checkbox-mixed-hover 2 png
new file mode 100644
index 0000000..cf571a8
Binary files /dev/null and b/themes/Adwaita/gtk-3.0/assets/checkbox-mixed-hover 2 png differ
diff --git a/themes/Adwaita/gtk-3.0/assets/checkbox-unchecked-hover-dark 2 png
b/themes/Adwaita/gtk-3.0/assets/checkbox-unchecked-hover-dark 2 png
new file mode 100644
index 0000000..9b63de5
Binary files /dev/null and b/themes/Adwaita/gtk-3.0/assets/checkbox-unchecked-hover-dark 2 png differ
diff --git a/themes/Adwaita/gtk-3.0/assets/checkbox-unchecked-hover 2 png
b/themes/Adwaita/gtk-3.0/assets/checkbox-unchecked-hover 2 png
new file mode 100644
index 0000000..3a1c3f5
Binary files /dev/null and b/themes/Adwaita/gtk-3.0/assets/checkbox-unchecked-hover 2 png differ
diff --git a/themes/Adwaita/gtk-3.0/gtk-widgets-assets-dark.css
b/themes/Adwaita/gtk-3.0/gtk-widgets-assets-dark.css
index 27c0a6c..9b7872e 100644
--- a/themes/Adwaita/gtk-3.0/gtk-widgets-assets-dark.css
+++ b/themes/Adwaita/gtk-3.0/gtk-widgets-assets-dark.css
@@ -54,6 +54,13 @@
background-position: center;
}
+.check:hover,
+.view.cell.check:hover {
+ background-image:
-gtk-scaled(url("assets/checkbox-unchecked-hover-dark.png"),url("assets/checkbox-unchecked-hover-dark 2
png"));
+ background-repeat: no-repeat;
+ background-position: center;
+}
+
.check:insensitive {
background-image:
-gtk-scaled(url("assets/checkbox-unchecked-insensitive-dark.png"),url("assets/checkbox-unchecked-insensitive-dark
2 png"));
}
@@ -78,6 +85,11 @@
background-image: -gtk-scaled(url("assets/checkbox-checked-dark.png"),url("assets/checkbox-checked-dark
2 png"));
}
+.check:active:hover,
+.view.cell.check:active:hover {
+ background-image:
-gtk-scaled(url("assets/checkbox-checked-hover-dark.png"),url("assets/checkbox-checked-hover-dark 2 png"));
+}
+
.check:active:insensitive {
background-image:
-gtk-scaled(url("assets/checkbox-checked-insensitive-dark.png"),url("assets/checkbox-checked-insensitive-dark
2 png"));
}
@@ -97,6 +109,10 @@
background-image: -gtk-scaled(url("assets/checkbox-mixed-dark.png"),url("assets/checkbox-mixed-dark 2
png"));
}
+.check:inconsistent:hover {
+ background-image:
-gtk-scaled(url("assets/checkbox-mixed-hover-dark.png"),url("assets/checkbox-mixed-hover-dark 2 png"));
+}
+
.check:inconsistent:insensitive {
background-image:
-gtk-scaled(url("assets/checkbox-mixed-insensitive-dark.png"),url("assets/checkbox-mixed-insensitive-dark 2
png"));
}
@@ -118,6 +134,13 @@
background-position: center;
}
+.radio:hover,
+.view.cell.radio:hover {
+ background-image:
-gtk-scaled(url("assets/radio-unchecked-hover-dark.png"),url("assets/radio-unchecked-hover-dark 2 png"));
+ background-repeat: no-repeat;
+ background-position: center;
+}
+
.radio:insensitive {
background-image:
-gtk-scaled(url("assets/radio-unchecked-insensitive-dark.png"),url("assets/radio-unchecked-insensitive-dark 2
png"));
}
@@ -142,6 +165,11 @@
background-image: -gtk-scaled(url("assets/radio-checked-dark.png"),url("assets/radio-checked-dark 2
png"));
}
+.radio:active:hover,
+.view.cell.radio:active:hover {
+ background-image:
-gtk-scaled(url("assets/radio-checked-hover-dark.png"),url("assets/radio-checked-hover-dark 2 png"));
+}
+
.radio:active:insensitive {
background-image:
-gtk-scaled(url("assets/radio-checked-insensitive-dark.png"),url("assets/radio-checked-insensitive-dark 2
png"));
}
@@ -161,6 +189,10 @@
background-image: -gtk-scaled(url("assets/radio-mixed-dark.png"),url("assets/radio-mixed-dark 2 png"));
}
+.radio:inconsistent:hover {
+ background-image:
-gtk-scaled(url("assets/radio-mixed-hover-dark.png"),url("assets/radio-mixed-hover-dark 2 png"));
+}
+
.radio:inconsistent:insensitive {
background-image:
-gtk-scaled(url("assets/radio-mixed-insensitive-dark.png"),url("assets/radio-mixed-insensitive-dark 2 png"));
}
diff --git a/themes/Adwaita/gtk-3.0/gtk-widgets-assets.css b/themes/Adwaita/gtk-3.0/gtk-widgets-assets.css
index 57523bd..2ac7fc1 100644
--- a/themes/Adwaita/gtk-3.0/gtk-widgets-assets.css
+++ b/themes/Adwaita/gtk-3.0/gtk-widgets-assets.css
@@ -56,6 +56,14 @@ GtkModelButton.button.check:hover,
background-position: center;
}
+GtkModelButton.button.check:hover,
+.check:hover,
+.view.cell.check:hover {
+ background-image:
-gtk-scaled(url("assets/checkbox-unchecked-hover.png"),url("assets/checkbox-unchecked-hover 2 png"));
+ background-repeat: no-repeat;
+ background-position: center;
+}
+
GtkModelButton.button.check:insensitive,
.check:insensitive {
background-image:
-gtk-scaled(url("assets/checkbox-unchecked-insensitive.png"),url("assets/checkbox-unchecked-insensitive 2
png"));
@@ -86,6 +94,12 @@ GtkModelButton.button.check:active:hover,
background-image: -gtk-scaled(url("assets/checkbox-checked.png"),url("assets/checkbox-checked 2 png"));
}
+GtkModelButton.button.check:active:hover,
+.check:active:hover,
+.view.cell.check:active:hover {
+ background-image:
-gtk-scaled(url("assets/checkbox-checked-hover.png"),url("assets/checkbox-checked-hover 2 png"));
+}
+
GtkModelButton.button.check:active:insensitive,
.check:active:insensitive {
background-image:
-gtk-scaled(url("assets/checkbox-checked-insensitive.png"),url("assets/checkbox-checked-insensitive 2 png"));
@@ -109,6 +123,10 @@ GtkModelButton.button.check:active:insensitive:backdrop,
background-image: -gtk-scaled(url("assets/checkbox-mixed.png"),url("assets/checkbox-mixed 2 png"));
}
+.check:inconsistent:hover {
+ background-image: -gtk-scaled(url("assets/checkbox-mixed-hover.png"),url("assets/checkbox-mixed-hover 2
png"));
+}
+
.check:inconsistent:insensitive {
background-image:
-gtk-scaled(url("assets/checkbox-mixed-insensitive.png"),url("assets/checkbox-mixed-insensitive 2 png"));
}
@@ -124,7 +142,6 @@ GtkModelButton.button.check:active:insensitive:backdrop,
}
GtkModelButton.button.radio,
-GtkModelButton.button.radio:hover,
.radio,
.view.cell.radio {
background-image: -gtk-scaled(url("assets/radio-unchecked.png"),url("assets/radio-unchecked 2 png"));
@@ -132,6 +149,14 @@ GtkModelButton.button.radio:hover,
background-position: center;
}
+GtkModelButton.button.radio:hover,
+.radio:hover,
+.view.cell.radio:hover {
+ background-image: -gtk-scaled(url("assets/radio-unchecked-hover.png"),url("assets/radio-unchecked-hover
2 png"));
+ background-repeat: no-repeat;
+ background-position: center;
+}
+
GtkModelButton.button.radio:insensitive,
.radio:insensitive {
background-image:
-gtk-scaled(url("assets/radio-unchecked-insensitive.png"),url("assets/radio-unchecked-insensitive 2 png"));
@@ -162,6 +187,13 @@ GtkModelButton.button.radio:active:hover,
background-image: -gtk-scaled(url("assets/radio-checked.png"),url("assets/radio-checked 2 png"));
}
+GtkModelButton.button.radio:active:hover,
+.radio:active:hover,
+.view.cell.radio:active:hover {
+ background-image: -gtk-scaled(url("assets/radio-checked-hover.png"),url("assets/radio-checked-hover 2
png"));
+}
+
+
GtkModelButton.button.radio:active:insensitive,
.radio:active:insensitive {
background-image:
-gtk-scaled(url("assets/radio-checked-insensitive.png"),url("assets/radio-checked-insensitive 2 png"));
@@ -185,6 +217,10 @@ GtkModelButton.button.radio:active:insensitive:backdrop,
background-image: -gtk-scaled(url("assets/radio-mixed.png"),url("assets/radio-mixed 2 png"));
}
+.radio:inconsistent:hover {
+ background-image: -gtk-scaled(url("assets/radio-mixed-hover.png"),url("assets/radio-mixed-hover 2 png"));
+}
+
.radio:inconsistent:insensitive {
background-image:
-gtk-scaled(url("assets/radio-mixed-insensitive.png"),url("assets/radio-mixed-insensitive 2 png"));
}
diff --git a/themes/Adwaita/gtk-3.0/gtk.gresource.xml b/themes/Adwaita/gtk-3.0/gtk.gresource.xml
index c9a6736..4e33c10 100644
--- a/themes/Adwaita/gtk-3.0/gtk.gresource.xml
+++ b/themes/Adwaita/gtk-3.0/gtk.gresource.xml
@@ -9,12 +9,16 @@
<file preprocess="to-pixdata">assets/checkbox-checked-backdrop-insensitive 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-checked-backdrop.png</file>
<file preprocess="to-pixdata">assets/checkbox-checked-backdrop 2 png</file>
+ <file preprocess="to-pixdata">assets/checkbox-checked-hover-dark.png</file>
+ <file preprocess="to-pixdata">assets/checkbox-checked-hover-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-checked-dark.png</file>
<file preprocess="to-pixdata">assets/checkbox-checked-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-checked-insensitive-dark.png</file>
<file preprocess="to-pixdata">assets/checkbox-checked-insensitive-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-checked-insensitive.png</file>
<file preprocess="to-pixdata">assets/checkbox-checked-insensitive 2 png</file>
+ <file preprocess="to-pixdata">assets/checkbox-checked-hover.png</file>
+ <file preprocess="to-pixdata">assets/checkbox-checked-hover 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-checked.png</file>
<file preprocess="to-pixdata">assets/checkbox-checked 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-backdrop-dark.png</file>
@@ -25,12 +29,16 @@
<file preprocess="to-pixdata">assets/checkbox-mixed-backdrop-insensitive 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-backdrop.png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-backdrop 2 png</file>
+ <file preprocess="to-pixdata">assets/checkbox-mixed-hover-dark.png</file>
+ <file preprocess="to-pixdata">assets/checkbox-mixed-hover-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-dark.png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-insensitive-dark.png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-insensitive-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-insensitive.png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed-insensitive 2 png</file>
+ <file preprocess="to-pixdata">assets/checkbox-mixed-hover.png</file>
+ <file preprocess="to-pixdata">assets/checkbox-mixed-hover 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed.png</file>
<file preprocess="to-pixdata">assets/checkbox-mixed 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-backdrop-dark.png</file>
@@ -41,12 +49,16 @@
<file preprocess="to-pixdata">assets/checkbox-unchecked-backdrop-insensitive 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-backdrop.png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-backdrop 2 png</file>
+ <file preprocess="to-pixdata">assets/checkbox-unchecked-hover-dark.png</file>
+ <file preprocess="to-pixdata">assets/checkbox-unchecked-hover-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-dark.png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-insensitive-dark.png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-insensitive-dark 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-insensitive.png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked-insensitive 2 png</file>
+ <file preprocess="to-pixdata">assets/checkbox-unchecked-hover.png</file>
+ <file preprocess="to-pixdata">assets/checkbox-unchecked-hover 2 png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked.png</file>
<file preprocess="to-pixdata">assets/checkbox-unchecked 2 png</file>
<file preprocess="to-pixdata">assets/dnd-counter.svg</file>
@@ -88,12 +100,16 @@
<file preprocess="to-pixdata">assets/radio-checked-backdrop-insensitive 2 png</file>
<file preprocess="to-pixdata">assets/radio-checked-backdrop.png</file>
<file preprocess="to-pixdata">assets/radio-checked-backdrop 2 png</file>
+ <file preprocess="to-pixdata">assets/radio-checked-hover-dark.png</file>
+ <file preprocess="to-pixdata">assets/radio-checked-hover-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-checked-dark.png</file>
<file preprocess="to-pixdata">assets/radio-checked-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-checked-insensitive-dark.png</file>
<file preprocess="to-pixdata">assets/radio-checked-insensitive-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-checked-insensitive.png</file>
<file preprocess="to-pixdata">assets/radio-checked-insensitive 2 png</file>
+ <file preprocess="to-pixdata">assets/radio-checked-hover.png</file>
+ <file preprocess="to-pixdata">assets/radio-checked-hover 2 png</file>
<file preprocess="to-pixdata">assets/radio-checked.png</file>
<file preprocess="to-pixdata">assets/radio-checked 2 png</file>
<file preprocess="to-pixdata">assets/radio-mixed-backdrop-dark.png</file>
@@ -104,12 +120,16 @@
<file preprocess="to-pixdata">assets/radio-mixed-backdrop-insensitive 2 png</file>
<file preprocess="to-pixdata">assets/radio-mixed-backdrop.png</file>
<file preprocess="to-pixdata">assets/radio-mixed-backdrop 2 png</file>
+ <file preprocess="to-pixdata">assets/radio-mixed-hover-dark.png</file>
+ <file preprocess="to-pixdata">assets/radio-mixed-hover-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-mixed-dark.png</file>
<file preprocess="to-pixdata">assets/radio-mixed-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-mixed-insensitive-dark.png</file>
<file preprocess="to-pixdata">assets/radio-mixed-insensitive-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-mixed-insensitive.png</file>
<file preprocess="to-pixdata">assets/radio-mixed-insensitive 2 png</file>
+ <file preprocess="to-pixdata">assets/radio-mixed-hover.png</file>
+ <file preprocess="to-pixdata">assets/radio-mixed-hover 2 png</file>
<file preprocess="to-pixdata">assets/radio-mixed.png</file>
<file preprocess="to-pixdata">assets/radio-mixed 2 png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-backdrop-dark.png</file>
@@ -120,12 +140,16 @@
<file preprocess="to-pixdata">assets/radio-unchecked-backdrop-insensitive 2 png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-backdrop.png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-backdrop 2 png</file>
+ <file preprocess="to-pixdata">assets/radio-unchecked-hover-dark.png</file>
+ <file preprocess="to-pixdata">assets/radio-unchecked-hover-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-dark.png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-insensitive-dark.png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-insensitive-dark 2 png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-insensitive.png</file>
<file preprocess="to-pixdata">assets/radio-unchecked-insensitive 2 png</file>
+ <file preprocess="to-pixdata">assets/radio-unchecked-hover.png</file>
+ <file preprocess="to-pixdata">assets/radio-unchecked-hover 2 png</file>
<file preprocess="to-pixdata">assets/radio-unchecked.png</file>
<file preprocess="to-pixdata">assets/radio-unchecked 2 png</file>
<file preprocess="to-pixdata">assets/resize-grip.svg</file>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]