[gnome-online-accounts/gnome-3-12] identity: fix another principal leak
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts/gnome-3-12] identity: fix another principal leak
- Date: Fri, 9 May 2014 12:55:45 +0000 (UTC)
commit 75cb553b79cdf3dcc6ff5eba07a5f8a5b8cb59a6
Author: Ray Strode <rstrode redhat com>
Date: Fri May 9 07:29:45 2014 -0400
identity: fix another principal leak
Spotted by valgrind.
https://bugzilla.gnome.org/show_bug.cgi?id=729865
src/goaidentity/goakerberosidentity.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c
index 1c2ba17..119bc18 100644
--- a/src/goaidentity/goakerberosidentity.c
+++ b/src/goaidentity/goakerberosidentity.c
@@ -240,7 +240,7 @@ get_identifier (GoaKerberosIdentity *self,
krb5_principal principal;
krb5_error_code error_code;
char *unparsed_name;
- char *identifier;
+ char *identifier = NULL;
if (self->priv->credentials_cache == NULL)
return NULL;
@@ -286,12 +286,14 @@ get_identifier (GoaKerberosIdentity *self,
g_debug ("GoaKerberosIdentity: Error parsing principal identity name: %s",
error_message);
krb5_free_error_message (self->priv->kerberos_context, error_message);
- return NULL;
+ goto out;
}
identifier = g_strdup (unparsed_name);
krb5_free_unparsed_name (self->priv->kerberos_context, unparsed_name);
+out:
+ krb5_free_principal (self->priv->kerberos_context, principal);
return identifier;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]