[geary] New composer crashes Geary: Refs bug #730483
- From: Jim Nelson <jnelson src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [geary] New composer crashes Geary: Refs bug #730483
- Date: Wed, 21 May 2014 01:19:12 +0000 (UTC)
commit 9dbd0d3d181712540a54e8ebe9c8904be061a381
Author: Jim Nelson <jim yorba org>
Date: Tue May 20 18:14:44 2014 -0700
New composer crashes Geary: Refs bug #730483
Don't start the progress monitor unless it's not running. Related
to fix for bug #728936 which dealt with reentrancy while folder is
opening. Suspect this is a timing issue.
.../imap-engine/imap-engine-minimal-folder.vala | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/src/engine/imap-engine/imap-engine-minimal-folder.vala
b/src/engine/imap-engine/imap-engine-minimal-folder.vala
index a71e122..f5b7423 100644
--- a/src/engine/imap-engine/imap-engine-minimal-folder.vala
+++ b/src/engine/imap-engine/imap-engine-minimal-folder.vala
@@ -544,7 +544,8 @@ private class Geary.ImapEngine.MinimalFolder : Geary.AbstractFolder, Geary.Folde
// to ensure this isn't running when open_remote_async() is called again (due to a connection
// reestablishment), stop this monitoring from running *before* launching close_internal_async
// ... in essence, guard against reentrancy, which is possible
- opening_monitor.notify_start();
+ if (!opening_monitor.is_in_progress)
+ opening_monitor.notify_start();
// following blocks of code are fairly tricky because if the remote open fails need to
// carefully back out and possibly retry
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]