[gdm] worker: Don't uninitialize pam before initialized if PostLogin fails
- From: Ray Strode <halfline src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gdm] worker: Don't uninitialize pam before initialized if PostLogin fails
- Date: Thu, 22 May 2014 16:32:13 +0000 (UTC)
commit 39e66b0e82b9cdc843820877506701eec0658aa5
Author: Ray Strode <rstrode redhat com>
Date: Thu May 22 12:29:48 2014 -0400
worker: Don't uninitialize pam before initialized if PostLogin fails
This commit cleans up a problem in an error path in open_session
(when PostLogin fails). At that point PAM has not been initialized,
so we shouldn't uninitialize it.
https://bugzilla.gnome.org/show_bug.cgi?id=730572
daemon/gdm-session-worker.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/daemon/gdm-session-worker.c b/daemon/gdm-session-worker.c
index 9ba5e89..8af97b0 100644
--- a/daemon/gdm-session-worker.c
+++ b/daemon/gdm-session-worker.c
@@ -2157,7 +2157,7 @@ gdm_session_worker_open_session (GdmSessionWorker *worker,
GDM_SESSION_WORKER_ERROR,
GDM_SESSION_WORKER_ERROR_OPENING_SESSION,
"Failed to execute PostLogin script");
- goto out;
+ return FALSE;
}
error_code = pam_open_session (worker->priv->pam_handle, flags);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]