[polari] chatView: Also show notifications for highlights in non-active rooms
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari] chatView: Also show notifications for highlights in non-active rooms
- Date: Tue, 27 May 2014 00:24:40 +0000 (UTC)
commit c03acb55f8ae97e74d78f233018d74ff01955b1e
Author: Florian Müllner <fmuellner gnome org>
Date: Thu May 8 10:31:32 2014 +0200
chatView: Also show notifications for highlights in non-active rooms
Currently we only show notifications while Polari is not focused.
However it makes sense to also show them when focused, when the
highlight was in a non-active room - while the room list will indicate
that there was a highlight, showing the actual message helps users
decide on whether to interrupt their current activity or not.
src/chatView.js | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/src/chatView.js b/src/chatView.js
index 2a02f90..2ecd134 100644
--- a/src/chatView.js
+++ b/src/chatView.js
@@ -642,7 +642,8 @@ const ChatView = new Lang.Class({
let [id, valid] = tpMessage.get_pending_message_id();
- if (message.shouldHighlight && !this._toplevelFocus) {
+ if (message.shouldHighlight &&
+ !(this._toplevelFocus && this._active)) {
let summary = '%s %s'.format(this._room.display_name, message.nick);
let notification = new Gio.Notification();
notification.set_title(summary);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]