[gnome-online-accounts/gnome-3-10] kerberos: drop weird, superfluous assignment in query function



commit 6cef0103da12bfafe68a65172569e0a5df754c73
Author: Ray Strode <rstrode redhat com>
Date:   Tue Nov 4 09:16:44 2014 -0500

    kerberos: drop weird, superfluous assignment in query function
    
    goa_kerberos_identity_inquiry_answer_query has this strange code:
    
    g_return_if_fail (inquiry == kerberos_query->inquiry);
    ...
    inquiry = kerberos_query->inquiry;
    
    It's completely redundant and makes no sense so drop it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739593

 src/goaidentity/goakerberosidentityinquiry.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/src/goaidentity/goakerberosidentityinquiry.c b/src/goaidentity/goakerberosidentityinquiry.c
index 547e254..60b0808 100644
--- a/src/goaidentity/goakerberosidentityinquiry.c
+++ b/src/goaidentity/goakerberosidentityinquiry.c
@@ -270,8 +270,6 @@ goa_kerberos_identity_inquiry_answer_query (GoaIdentityInquiry * inquiry,
 
   self = GOA_KERBEROS_IDENTITY_INQUIRY (inquiry);
 
-  inquiry = kerberos_query->inquiry;
-
   strncpy (kerberos_query->kerberos_prompt->reply->data,
            answer, kerberos_query->kerberos_prompt->reply->length);
   kerberos_query->kerberos_prompt->reply->length =


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]