[gnome-boxes] spice-display: Remove 'Resize guest' property
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes] spice-display: Remove 'Resize guest' property
- Date: Sat, 8 Nov 2014 18:26:24 +0000 (UTC)
commit 9e8fee90f2c9a80abb742d2d84754ed46ec49b74
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date: Sat Nov 8 18:19:25 2014 +0000
spice-display: Remove 'Resize guest' property
Tell SPICE to always try to resize the guest display to allocated size,
instead of exposing this internal detail to users. Not only is this
property non-obvious to most people, we have had some weird side-effects
from people disabling this property in the past.
See the bug below for discussion leading to removal of this option.
https://bugzilla.gnome.org/show_bug.cgi?id=729700
src/spice-display.vala | 14 +-------------
1 files changed, 1 insertions(+), 13 deletions(-)
---
diff --git a/src/spice-display.vala b/src/spice-display.vala
index e6f4466..ddfb681 100644
--- a/src/spice-display.vala
+++ b/src/spice-display.vala
@@ -18,13 +18,12 @@ private class Boxes.SpiceDisplay: Boxes.Display {
private BoxConfig.SyncProperty[] gtk_session_sync_properties;
private bool closed;
- public bool resize_guest { get; set; }
private void ui_state_changed () {
// TODO: multi display
if (machine.ui_state == UIState.DISPLAY) {
// disable resize guest when minimizing guest widget
var display = get_display (0) as Spice.Display;
- display.resize_guest = resize_guest;
+ display.resize_guest = true;
}
}
@@ -34,10 +33,6 @@ private class Boxes.SpiceDisplay: Boxes.Display {
}
construct {
- display_sync_properties = {
- BoxConfig.SyncProperty () { name = "resize-guest", default_value = true }
- };
-
gtk_session_sync_properties = {
BoxConfig.SyncProperty () { name = "auto-clipboard", default_value = true },
BoxConfig.SyncProperty () { name = "auto-usbredir", default_value = false }
@@ -179,7 +174,6 @@ private class Boxes.SpiceDisplay: Boxes.Display {
public override void collect_logs (StringBuilder builder) {
builder.append_printf ("URI: %s\n", uri);
- builder.append_printf ("Auto resize guest: %s\n", resize_guest ? "yes" : "no");
if (gtk_session != null) {
builder.append_printf ("Auto redirect USB: %s\n", gtk_session.auto_usbredir ? "yes" : "no");
builder.append_printf ("Auto clipboard sync: %s\n", gtk_session.auto_clipboard ? "yes" : "no");
@@ -292,12 +286,6 @@ private class Boxes.SpiceDisplay: Boxes.Display {
BindingFlags.BIDIRECTIONAL | BindingFlags.SYNC_CREATE);
toggle.halign = Gtk.Align.START;
add_property (ref list, _("Share clipboard"), toggle);
-
- toggle = new Gtk.Switch ();
- this.bind_property ("resize-guest", toggle, "active",
- BindingFlags.BIDIRECTIONAL | BindingFlags.SYNC_CREATE);
- toggle.halign = Gtk.Align.START;
- add_property (ref list, _("Resize guest"), toggle);
break;
case PropertiesPage.DEVICES:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]