[gnome-boxes/gnome-3-14] wizard: Remove redundant & problematic check
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes/gnome-3-14] wizard: Remove redundant & problematic check
- Date: Sun, 12 Oct 2014 18:30:14 +0000 (UTC)
commit a3dc8c49e86cb7dd6d5a962cb0eaf593dc6da882
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date: Tue Sep 30 14:38:32 2014 +0100
wizard: Remove redundant & problematic check
For some reason we have been bailing out on URLs if their mime-type
could be detected with 100% certainty. While I don't recall exactly why
this was added back in the days, I'm pretty sure its not needed right
now. At the very least, this check fails when Boxes is given URL of
remote non-ISO (import) images.
https://bugzilla.gnome.org/show_bug.cgi?id=737113
src/wizard.vala | 16 +---------------
1 files changed, 1 insertions(+), 15 deletions(-)
---
diff --git a/src/wizard.vala b/src/wizard.vala
index 5d370d0..00d5581 100644
--- a/src/wizard.vala
+++ b/src/wizard.vala
@@ -275,21 +275,7 @@ private class Boxes.Wizard: Gtk.Stack, Boxes.UI {
return;
}
- bool uncertain;
- var uri = file.get_uri ();
-
- var mimetype = ContentType.guess (uri, null, out uncertain);
-
- if (uncertain) {
- prepare_for_uri (uri);
-
- return;
- }
-
- debug ("Can't handle remote location '%s' (mime type: '%s')",
- uri,
- ContentType.get_mime_type (mimetype));
- throw new Boxes.Error.INVALID (_("Invalid URI"));
+ prepare_for_uri (file.get_uri ());
}
private void prepare_for_uri (string uri_as_text) throws Boxes.Error {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]