[mutter] core: end-of-grab button releases must be consumed by the window



commit 8819d9ce66a33f73f84d9105091302420b1d498c
Author: Carlos Garnacho <carlosg gnome org>
Date:   Mon Oct 20 18:26:25 2014 +0200

    core: end-of-grab button releases must be consumed by the window
    
    Returning FALSE here gets the button release event propagated to the
    client on wayland, which is unexpected after xdg_surface.move/resize()
    have been called.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738888

 src/core/window.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/src/core/window.c b/src/core/window.c
index 0bc85d8..8ef7581 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -6110,10 +6110,8 @@ meta_window_handle_mouse_grab_op_event  (MetaWindow         *window,
     case CLUTTER_BUTTON_RELEASE:
       if (event->button.button == 1 ||
           event->button.button == (unsigned int) meta_prefs_get_mouse_button_resize ())
-        {
-          end_grab_op (window, event);
-          return FALSE;
-        }
+        end_grab_op (window, event);
+
       return TRUE;
 
     case CLUTTER_TOUCH_BEGIN:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]