[totem] grilo: Limit ourselves to running one thumbnailer at a time
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [totem] grilo: Limit ourselves to running one thumbnailer at a time
- Date: Fri, 24 Apr 2015 15:28:10 +0000 (UTC)
commit 89693505eac61cc2f6ccd5a33e07ac5d8c4a7126
Author: Bastien Nocera <hadess hadess net>
Date: Fri Apr 24 17:17:36 2015 +0200
grilo: Limit ourselves to running one thumbnailer at a time
Our thumbnailer currently doesn't have support for using hardware
decoding, so it's pretty CPU intensive. On my machine (i7 laptop with an
SSD), one thumbnailer would take about 40% of CPU. This causes both lag
when navigating the videos list, and carries on hampering video playback
if thumbnailing is started before playback.
This is good enough to mark this bug as fixed:
https://bugzilla.gnome.org/show_bug.cgi?id=748370
though a better solution would be to cancel thumbnailing in
totem_grilo_pause(), make sure that
gnome_desktop_thumbnail_path_for_uri() is cancellable, and try to
distinguish in totem-grilo.c between cancellation because the player is
getting shut down, and cancellation because we want all the resources to
go to the player.
src/icon-helpers.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/icon-helpers.c b/src/icon-helpers.c
index 53d923e..b870054 100644
--- a/src/icon-helpers.c
+++ b/src/icon-helpers.c
@@ -30,7 +30,7 @@
#define GNOME_DESKTOP_USE_UNSTABLE_API 1
#include <libgnome-desktop/gnome-desktop-thumbnail.h>
-#define DEFAULT_MAX_THREADS 5
+#define DEFAULT_MAX_THREADS 1
#define THUMB_SEARCH_SIZE 256
#define THUMB_SEARCH_HEIGHT THUMB_SEARCH_SIZE
#define SOURCES_MAX_HEIGHT 64
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]