[gtk+] listbox: Avoid using show_all on rows
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] listbox: Avoid using show_all on rows
- Date: Sat, 8 Aug 2015 15:29:56 +0000 (UTC)
commit d6f51ef7b299f0bdc7522ced74482c510dc947b4
Author: Kalev Lember <klember redhat com>
Date: Sat Aug 8 16:33:42 2015 +0200
listbox: Avoid using show_all on rows
Don't use gtk_widget_show_all() on row widgets because that would
unconditionally show all of its children. This might be unwanted in case
the row implementation wants to keep some of its children hidden.
This commit changes it to use show() instead of show_all() and relies on
the row widget to control the visibility of its children itself as
appropriate.
https://bugzilla.gnome.org/show_bug.cgi?id=753392
gtk/gtklistbox.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtklistbox.c b/gtk/gtklistbox.c
index e6846d2..9de26ca 100644
--- a/gtk/gtklistbox.c
+++ b/gtk/gtklistbox.c
@@ -3684,7 +3684,7 @@ gtk_list_box_bound_model_changed (GListModel *list,
if (g_object_is_floating (widget))
g_object_ref_sink (widget);
- gtk_widget_show_all (widget);
+ gtk_widget_show (widget);
gtk_list_box_insert (box, widget, position + i);
g_object_unref (widget);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]