[gtk+] popover: Optimize the transition
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] popover: Optimize the transition
- Date: Sun, 16 Aug 2015 02:03:34 +0000 (UTC)
commit 84bd32a09a25bee24ae7740e30bd75727695d744
Author: Matthias Clasen <mclasen redhat com>
Date: Sat Aug 15 22:02:40 2015 -0400
popover: Optimize the transition
There's no need to queue a resize here.
https://bugzilla.gnome.org/show_bug.cgi?id=753568
gtk/gtkpopover.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/gtk/gtkpopover.c b/gtk/gtkpopover.c
index e7f3e69..6769775 100644
--- a/gtk/gtkpopover.c
+++ b/gtk/gtkpopover.c
@@ -518,8 +518,6 @@ show_animate_cb (GtkWidget *widget,
gtk_widget_set_opacity (widget, 1.0 - t);
}
- gtk_widget_queue_resize (GTK_WIDGET (popover));
-
if (t >= 1.0)
{
if (priv->state == STATE_SHOWING)
@@ -532,10 +530,10 @@ show_animate_cb (GtkWidget *widget,
else
gtk_popover_set_state (popover, STATE_HIDDEN);
- return FALSE;
+ return G_SOURCE_REMOVE;
}
else
- return TRUE;
+ return G_SOURCE_CONTINUE;
}
static void
@@ -575,7 +573,7 @@ gtk_popover_set_state (GtkPopover *popover,
gtk_popover_start_transition (popover);
else
{
- if (priv->tick_id)
+ if (priv->tick_id != 0)
{
gtk_widget_remove_tick_callback (GTK_WIDGET (popover), priv->tick_id);
priv->tick_id = 0;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]