[file-roller] Don't destroy attached menus
- From: Paolo Bacchilega <paobac src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [file-roller] Don't destroy attached menus
- Date: Sat, 22 Aug 2015 05:21:34 +0000 (UTC)
commit b56cb8703e0a5f6a337ddf55c4cb3b5c9768a77e
Author: Matthias Clasen <mclasen redhat com>
Date: Fri Aug 21 17:53:36 2015 -0400
Don't destroy attached menus
The documentation for gtk_menu_attach_to_widget states that
attached menus are destroyed together with their attach_widget,
like child widgets. Destroying them manually leads to bad things,
such as segfaults.
https://bugzilla.gnome.org/show_bug.cgi?id=753951
src/fr-window.c | 15 ---------------
1 files changed, 0 insertions(+), 15 deletions(-)
---
diff --git a/src/fr-window.c b/src/fr-window.c
index d27e00f..b9f128f 100644
--- a/src/fr-window.c
+++ b/src/fr-window.c
@@ -540,21 +540,6 @@ fr_window_free_private_data (FrWindow *window)
_g_string_list_free (window->priv->drag_file_list);
window->priv->drag_file_list = NULL;
- if (window->priv->file_popup_menu != NULL) {
- gtk_widget_destroy (window->priv->file_popup_menu);
- window->priv->file_popup_menu = NULL;
- }
-
- if (window->priv->folder_popup_menu != NULL) {
- gtk_widget_destroy (window->priv->folder_popup_menu);
- window->priv->folder_popup_menu = NULL;
- }
-
- if (window->priv->sidebar_folder_popup_menu != NULL) {
- gtk_widget_destroy (window->priv->sidebar_folder_popup_menu);
- window->priv->sidebar_folder_popup_menu = NULL;
- }
-
g_free (window->priv->last_location);
fr_window_free_batch_data (window);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]