[nautilus] window-slot: don't increase references on dispose...
- From: Carlos Soriano Sánchez <csoriano src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus] window-slot: don't increase references on dispose...
- Date: Fri, 11 Dec 2015 22:06:12 +0000 (UTC)
commit fd2685f838e613387179968d8e0b1326fe503a16
Author: Carlos Soriano <csoriano gnome org>
Date: Fri Dec 11 23:00:18 2015 +0100
window-slot: don't increase references on dispose...
It's clearly wrong. The TODO doesn't make it better :)
We are leaking few of GFiles already...
src/nautilus-window-slot.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/src/nautilus-window-slot.c b/src/nautilus-window-slot.c
index a040952..6c675df 100644
--- a/src/nautilus-window-slot.c
+++ b/src/nautilus-window-slot.c
@@ -2277,11 +2277,7 @@ nautilus_window_slot_dispose (GObject *object)
nautilus_window_slot_set_viewed_file (slot, NULL);
- if (slot->details->location) {
- /* TODO? why do we ref here, instead of unreffing?
- * It was already here before the slot migration, though */
- g_object_ref (slot->details->location);
- }
+ g_clear_object (&slot->details->location);
if (slot->details->view_mode_before_search) {
g_free (slot->details->view_mode_before_search);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]