[gnome-photos/wip/rishi/misc-fixes: 13/13] pipeline: Silence a WARNING by working around a GEGL bug
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-photos/wip/rishi/misc-fixes: 13/13] pipeline: Silence a WARNING by working around a GEGL bug
- Date: Wed, 30 Dec 2015 11:48:45 +0000 (UTC)
commit d65aa4b2461db48a17f664cbd6a73b564933b6a3
Author: Debarshi Ray <debarshir gnome org>
Date: Tue Dec 29 22:29:02 2015 +0100
pipeline: Silence a WARNING by working around a GEGL bug
src/photos-pipeline.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/src/photos-pipeline.c b/src/photos-pipeline.c
index 03354a3..604a861 100644
--- a/src/photos-pipeline.c
+++ b/src/photos-pipeline.c
@@ -136,9 +136,17 @@ photos_pipeline_dispose (GObject *object)
{
PhotosPipeline *self = PHOTOS_PIPELINE (object);
+ /* We must drop all references to the child nodes before destroying
+ * the graph. The other option would be to ensure that the
+ * GeglProcessor is destroyed before its Pipeline, but since that is
+ * harder to enforce, let's do this instead.
+ *
+ * See: https://bugzilla.gnome.org/show_bug.cgi?id=759995
+ */
+ g_clear_pointer (&self->hash, (GDestroyNotify) g_hash_table_unref);
+
g_clear_object (&self->graph);
g_clear_object (&self->parent);
- g_clear_pointer (&self->hash, (GDestroyNotify) g_hash_table_unref);
G_OBJECT_CLASS (photos_pipeline_parent_class)->dispose (object);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]