[gnome-software] shell search provider: Minor cleanup for dispose
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] shell search provider: Minor cleanup for dispose
- Date: Sun, 7 Jun 2015 16:00:24 +0000 (UTC)
commit a9f78a9c030b3f5f7b34b99cb2a44cf37d1d0924
Author: Kalev Lember <kalevlember gmail com>
Date: Sun Jun 7 15:43:56 2015 +0200
shell search provider: Minor cleanup for dispose
Avoid clearing the cancellable object twice and add a guard make sure
that g_hash_table_destroy() isn't called twice.
src/gs-shell-search-provider.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/src/gs-shell-search-provider.c b/src/gs-shell-search-provider.c
index 109c690..675dfb2 100644
--- a/src/gs-shell-search-provider.c
+++ b/src/gs-shell-search-provider.c
@@ -329,10 +329,13 @@ search_provider_dispose (GObject *obj)
g_clear_object (&self->cancellable);
}
+ if (self->metas_cache != NULL) {
+ g_hash_table_destroy (self->metas_cache);
+ self->metas_cache = NULL;
+ }
+
g_clear_object (&self->object_manager);
g_clear_object (&self->plugin_loader);
- g_clear_object (&self->cancellable);
- g_hash_table_destroy (self->metas_cache);
g_application_release (g_application_get_default ());
G_OBJECT_CLASS (gs_shell_search_provider_parent_class)->dispose (obj);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]