[gnome-shell/wip/fmuellner/chat-notifications: 3/5] messageTray: Always destroy banners when done displaying



commit d7ff7e062bf846ff9cd0f628bb1d976f745427b3
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Mar 11 17:25:25 2015 +0100

    messageTray: Always destroy banners when done displaying
    
    Special-casing banners of resident notifications was really a
    thinly veiled special case for chat notifications, as those were
    still using the old notification actor which coupled the life-time
    of the notification to its actor. This is no longer the case, so
    we can do the sane thing and destroy banners once they are no
    longer needed.

 js/ui/messageTray.js |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 4d7d935..b69492b 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -2091,10 +2091,7 @@ const MessageTray = new Lang.Class({
         this._pointerInNotification = false;
         this._notificationRemoved = false;
 
-        if (notification.resident)
-            this._bannerBin.remove_actor(this._banner.actor);
-        else
-            this._banner.actor.destroy();
+        this._banner.actor.destroy();
         this._banner = null;
         this.actor.hide();
     },


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]