[gnome-initial-setup/shell/4765: 316/362] account: don't double-unref GClosure



commit 828da06bb338b0b62f87703efba32212683cd1bb
Author: Cosimo Cecchi <cosimo endlesm com>
Date:   Tue Dec 30 15:44:44 2014 +0800

    account: don't double-unref GClosure
    
    gtk_accel_group_connect() calls g_closure_sink() on the passed-in
    GClosure, so calling g_closure_unref() here is wrong as it will lead to
    a double unref. Spotted with valgrind.

 .../pages/account/gis-account-page.c               |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/gnome-initial-setup/pages/account/gis-account-page.c 
b/gnome-initial-setup/pages/account/gis-account-page.c
index 7f1301a..9b66dd5 100644
--- a/gnome-initial-setup/pages/account/gis-account-page.c
+++ b/gnome-initial-setup/pages/account/gis-account-page.c
@@ -1235,8 +1235,6 @@ gis_account_page_constructed (GObject *object)
 
   /* Use Ctrl+Alt+e to activate the enterprise login mode */
   gtk_accel_group_connect (priv->accel_group, GDK_KEY_e, GDK_CONTROL_MASK | GDK_MOD1_MASK, 0, closure);
-  g_closure_unref (closure);
- 
 
   /* force a refresh by setting to an invalid value */
   priv->mode = NUM_MODES;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]