[glib] g_local_file_trash: remove invalid free call
- From: Ryan Lortie <desrt src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib] g_local_file_trash: remove invalid free call
- Date: Fri, 6 Nov 2015 16:56:24 +0000 (UTC)
commit 90808a02796449615947e49ae57f5f4fa2e404ea
Author: Sebastien Bacher <seb128 ubuntu com>
Date: Fri Nov 6 17:42:45 2015 +0100
g_local_file_trash: remove invalid free call
Commit 8ece2de964c01b3428f16766f199b58f0bc67212 transplanted a block of
code that contained an early-exit-on-error case which freed several
variables.
Because of the move, the normal-path unconditional free of one of these
variables is now above this early exit case, so if this block is hit, it
will now be a double-free.
Remove that.
https://bugzilla.gnome.org/show_bug.cgi?id=757693
gio/glocalfile.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/gio/glocalfile.c b/gio/glocalfile.c
index 8758ee2..a5a6beb 100644
--- a/gio/glocalfile.c
+++ b/gio/glocalfile.c
@@ -2144,7 +2144,6 @@ g_local_file_trash (GFile *file,
g_unlink (infofile);
- g_free (topdir);
g_free (trashname);
g_free (infofile);
g_free (trashfile);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]