[nautilus] window-slot: don't ref all views on creation
- From: Carlos Soriano Sánchez <csoriano src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus] window-slot: don't ref all views on creation
- Date: Fri, 13 Nov 2015 17:58:26 +0000 (UTC)
commit f101c34c3dfe555d237c0a67876fc478ca8772a9
Author: Carlos Soriano <csoriano gnome org>
Date: Fri Nov 13 18:43:44 2015 +0100
window-slot: don't ref all views on creation
This was leaking and making that no view was finalized, leading
to all kind of problems and crashes due to signals and files updating
the dangling view, and not letting files to be released.
This was creating multiple non-related reports on Fedora Tracker making
nautilus one of the top crashers.
Downstream tracker bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1277625
The upcoming patch is also necessary for a complete fix.
src/nautilus-window-slot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/nautilus-window-slot.c b/src/nautilus-window-slot.c
index c32bde2..d005eee 100644
--- a/src/nautilus-window-slot.c
+++ b/src/nautilus-window-slot.c
@@ -228,7 +228,7 @@ nautilus_window_slot_get_view_for_location (NautilusWindowSlot *slot,
nautilus_file_unref (file);
- return g_object_ref (view);
+ return view;
}
static gboolean
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]