[gtk+] Assistant: Fix page rmoval
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] Assistant: Fix page rmoval
- Date: Thu, 29 Oct 2015 23:30:14 +0000 (UTC)
commit 32de7edf1dec5528b8d02cb765b2c76471f321c6
Author: Matthias Clasen <mclasen redhat com>
Date: Thu Oct 29 19:21:47 2015 -0400
Assistant: Fix page rmoval
We have to remove the page itself from the intermediate box
first, before removing the box from the notebook. Otherwise,
reffing the page to keep it alive is ineffective: the box
gets destroyed, and that destruction recurses over the page.
This fixes the problem in
https://bugzilla.gnome.org/show_bug.cgi?id=756385
gtk/gtkassistant.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtkassistant.c b/gtk/gtkassistant.c
index b1d400d..8813b4b 100644
--- a/gtk/gtkassistant.c
+++ b/gtk/gtkassistant.c
@@ -1472,8 +1472,8 @@ gtk_assistant_remove (GtkContainer *container,
assistant->priv->content != NULL &&
gtk_widget_get_parent (box) == assistant->priv->content)
{
- container = (GtkContainer *) assistant->priv->content;
- gtk_container_remove (container, box);
+ gtk_container_remove (GTK_CONTAINER (box), page);
+ gtk_container_remove (GTK_CONTAINER (assistant->priv->content), box);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]