[grilo-plugins] thetvdb: Use HTTPS rather than insecure HTTP

From: Victor Toso de Carvalho <victortoso src gnome org>
To: commits-list gnome org
Cc:
Subject: [grilo-plugins] thetvdb: Use HTTPS rather than insecure HTTP
Date: Thu, 3 Sep 2015 07:10:31 +0000 (UTC)
commit f4e44c23c15fd14eacf9bfaa5a40801ed94b941b
Author: Elad Alfassa <elad fedoraproject org>
Date:   Wed Sep 2 23:35:32 2015 +0300

    thetvdb: Use HTTPS rather than insecure HTTP
    
    To avoid leaking (potentially uniquely identifiable) user data over
    plain text (be it search phrases, hashes of contact emails, etc etc),
    use HTTPS whenever possible.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754489

 src/thetvdb/grl-thetvdb.c                     |    2 +-
 tests/thetvdb/data/config.ini                 |   26 ++++----
 tests/thetvdb/test_thetvdb_resolve_episodes.c |   10 ++--
 tests/thetvdb/test_thetvdb_resolve_shows.c    |   30 ++++----
 tests/thetvdb/test_thetvdb_resolve_stress.c   |   92 ++++++++++++------------
 5 files changed, 80 insertions(+), 80 deletions(-)
---
diff --git a/src/thetvdb/grl-thetvdb.c b/src/thetvdb/grl-thetvdb.c
index f00a020..a42fd59 100644
--- a/src/thetvdb/grl-thetvdb.c
+++ b/src/thetvdb/grl-thetvdb.c
@@ -47,7 +47,7 @@ GRL_LOG_DOMAIN_STATIC (thetvdb_log_domain);
 
 /* --- URLs --- */
 
-#define THETVDB_BASE        "http://thetvdb.com/";
+#define THETVDB_BASE        "https://thetvdb.com/";
 #define THETVDB_BASE_API    THETVDB_BASE "api/"
 #define THETVDB_BASE_IMG    THETVDB_BASE "banners/%s"
 
diff --git a/tests/thetvdb/data/config.ini b/tests/thetvdb/data/config.ini
index d711869..a1dd29b 100644
--- a/tests/thetvdb/data/config.ini
+++ b/tests/thetvdb/data/config.ini
@@ -2,40 +2,40 @@
 version=1
 
 # Boardwalk Empire
-[http://thetvdb.com/api/GetSeries.php?language=all&seriesname=Boardwalk Empire]
+[https://thetvdb.com/api/GetSeries.php?language=all&seriesname=Boardwalk Empire]
 data = boardwalk_empire_get_series.txt
-[http://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/84947/all/en.zip]
+[https://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/84947/all/en.zip]
 data = boardwalk_empire_series_all_en.zip
 
 # Adventure Time
-[http://thetvdb.com/api/GetSeries.php?language=all&seriesname=Adventure Time]
+[https://thetvdb.com/api/GetSeries.php?language=all&seriesname=Adventure Time]
 data = adventure_time_get_series.txt
-[http://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/152831/all/en.zip]
+[https://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/152831/all/en.zip]
 data = adventure_time_series_all_en.zip
 
 # Felicity
-[http://thetvdb.com/api/GetSeries.php?language=all&seriesname=Felicity]
+[https://thetvdb.com/api/GetSeries.php?language=all&seriesname=Felicity]
 data = felicity_get_series.txt
-[http://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/73980/all/en.zip]
+[https://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/73980/all/en.zip]
 data = felicity_series_all_en.zip
 
 # House
-[http://thetvdb.com/api/GetSeries.php?language=all&seriesname=House]
+[https://thetvdb.com/api/GetSeries.php?language=all&seriesname=House]
 data = house_get_series.txt
-[http://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/73255/all/en.zip]
+[https://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/73255/all/en.zip]
 data = house_series_all_en.zip
 
 # Naruto
-[http://thetvdb.com/api/GetSeries.php?language=all&seriesname=Naruto]
+[https://thetvdb.com/api/GetSeries.php?language=all&seriesname=Naruto]
 data = naruto_get_series.txt
-[http://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/78857/all/en.zip]
+[https://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/78857/all/en.zip]
 data = naruto_series_all_en.zip
 
 # CSI - Miami (fuzzy name)
-[http://thetvdb.com/api/GetSeries.php?language=all&seriesname=CSI - Miami]
+[https://thetvdb.com/api/GetSeries.php?language=all&seriesname=CSI - Miami]
 data = csi_miami_get_series.txt
-[http://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/78310/all/en.zip]
+[https://thetvdb.com/api/THETVDB_TEST_MOCK_API_KEY/series/78310/all/en.zip]
 data = csi_miami_series_all_en.zip
 
-[http://thetvdb.com/api/GetSeries.php?language=all&seriesname=les experts miami]
+[https://thetvdb.com/api/GetSeries.php?language=all&seriesname=les experts miami]
 data = les_experts_miami_get_series.txt
diff --git a/tests/thetvdb/test_thetvdb_resolve_episodes.c b/tests/thetvdb/test_thetvdb_resolve_episodes.c
index 3b1be19..1ea48d5 100644
--- a/tests/thetvdb/test_thetvdb_resolve_episodes.c
+++ b/tests/thetvdb/test_thetvdb_resolve_episodes.c
@@ -108,19 +108,19 @@ test_episodes_from_episode (void)
   } videos[] = {
     { "Boardwalk Empire", "New York Sour", 4, 1,
       "tt2483070", "4596908", "SH01308836", "2013-09-08",
-      "http://thetvdb.com/banners/episodes/84947/4596908.jpg"; },
+      "https://thetvdb.com/banners/episodes/84947/4596908.jpg"; },
     { "Adventure Time", "It Came from the Nightosphere", 2, 1,
       "tt1305826", "2923061", "EP01246265", "2010-10-11",
-      "http://thetvdb.com/banners/episodes/152831/2923061.jpg"; },
+      "https://thetvdb.com/banners/episodes/152831/2923061.jpg"; },
     { "Felicity", "The Last Stand", 1, 2,
       "tt0134247", "133911", "SH184561", "1998-10-06",
-      "http://thetvdb.com/banners/episodes/73980/133911.jpg"; },
+      "https://thetvdb.com/banners/episodes/73980/133911.jpg"; },
     { "House", "Everybody Dies", 8, 22,
       "tt2121965", "4265769", "EP00688359", "2012-05-21",
-      "http://thetvdb.com/banners/episodes/73255/4265769.jpg"; },
+      "https://thetvdb.com/banners/episodes/73255/4265769.jpg"; },
     { "Naruto", "Yakumo's Sealed Power", 5, 25,
       "tt0409591", "446714", "SH774951", "2006-10-05",
-      "http://thetvdb.com/banners/episodes/78857/446714.jpg"; }
+      "https://thetvdb.com/banners/episodes/78857/446714.jpg"; }
   };
 
   source = test_get_source();
diff --git a/tests/thetvdb/test_thetvdb_resolve_shows.c b/tests/thetvdb/test_thetvdb_resolve_shows.c
index 8a73844..4a758ea 100644
--- a/tests/thetvdb/test_thetvdb_resolve_shows.c
+++ b/tests/thetvdb/test_thetvdb_resolve_shows.c
@@ -129,25 +129,25 @@ test_shows (GrlResolutionFlags resolution,
     gchar *url_poster;
   } videos[] = {
     { "Boardwalk Empire", "tt0979432", "84947", "SH01308836", "2010-09-19",
-      "http://thetvdb.com/banners/graphical/84947-g6.jpg";,
-      "http://thetvdb.com/banners/fanart/original/84947-12.jpg";,
-      "http://thetvdb.com/banners/posters/84947-6.jpg"; },
+      "https://thetvdb.com/banners/graphical/84947-g6.jpg";,
+      "https://thetvdb.com/banners/fanart/original/84947-12.jpg";,
+      "https://thetvdb.com/banners/posters/84947-6.jpg"; },
     { "Adventure Time", "tt1305826", "152831", "EP01246265", "2010-04-05",
-      "http://thetvdb.com/banners/graphical/152831-g2.jpg";,
-      "http://thetvdb.com/banners/fanart/original/152831-13.jpg";,
-      "http://thetvdb.com/banners/posters/152831-2.jpg"; },
+      "https://thetvdb.com/banners/graphical/152831-g2.jpg";,
+      "https://thetvdb.com/banners/fanart/original/152831-13.jpg";,
+      "https://thetvdb.com/banners/posters/152831-2.jpg"; },
     { "Felicity", "tt0134247", "73980", "SH184561", "1998-09-29",
-      "http://thetvdb.com/banners/graphical/253-g.jpg";,
-      "http://thetvdb.com/banners/fanart/original/73980-3.jpg";,
-      "http://thetvdb.com/banners/posters/73980-4.jpg"; },
+      "https://thetvdb.com/banners/graphical/253-g.jpg";,
+      "https://thetvdb.com/banners/fanart/original/73980-3.jpg";,
+      "https://thetvdb.com/banners/posters/73980-4.jpg"; },
     { "House", "tt0412142", "73255", "EP00688359", "2004-11-16",
-      "http://thetvdb.com/banners/graphical/73255-g22.jpg";,
-      "http://thetvdb.com/banners/fanart/original/73255-47.jpg";,
-      "http://thetvdb.com/banners/posters/73255-13.jpg"; },
+      "https://thetvdb.com/banners/graphical/73255-g22.jpg";,
+      "https://thetvdb.com/banners/fanart/original/73255-47.jpg";,
+      "https://thetvdb.com/banners/posters/73255-13.jpg"; },
     { "Naruto", "tt0409591", "78857", "SH774951", "2002-10-03",
-      "http://thetvdb.com/banners/graphical/78857-g3.jpg";,
-      "http://thetvdb.com/banners/fanart/original/78857-37.jpg";,
-      "http://thetvdb.com/banners/posters/78857-10.jpg"; }
+      "https://thetvdb.com/banners/graphical/78857-g3.jpg";,
+      "https://thetvdb.com/banners/fanart/original/78857-37.jpg";,
+      "https://thetvdb.com/banners/posters/78857-10.jpg"; }
   };
 
   source = test_get_source ();
diff --git a/tests/thetvdb/test_thetvdb_resolve_stress.c b/tests/thetvdb/test_thetvdb_resolve_stress.c
index 5a760a3..0466fac 100644
--- a/tests/thetvdb/test_thetvdb_resolve_stress.c
+++ b/tests/thetvdb/test_thetvdb_resolve_stress.c
@@ -42,142 +42,142 @@ static struct {
 } videos[] = {
   {"House", "Now What?", 7, 1,
     "tt1697219", "2495251","EP00688359","2010-09-20",
-    "http://thetvdb.com/banners/episodes/73255/2495251.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2495251.jpg"; },
   {"House", "Selfish", 7, 2,
     "tt1685104", "2756371","EP00688359","2010-09-27",
-    "http://thetvdb.com/banners/episodes/73255/2756371.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2756371.jpg"; },
   {"House", "Unwritten", 7, 3,
     "tt1726377", "2825851","EP00688359","2010-10-04",
-    "http://thetvdb.com/banners/episodes/73255/2825851.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2825851.jpg"; },
   {"House", "Massage Therapy", 7, 4,
     "tt1726378", "2878681","EP00688359","2010-10-11",
-    "http://thetvdb.com/banners/episodes/73255/2878681.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2878681.jpg"; },
   {"House", "Unplanned Parenthood", 7, 5,
     "tt1726379", "2878691","EP00688359","2010-10-18",
-    "http://thetvdb.com/banners/episodes/73255/2878691.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2878691.jpg"; },
   {"House", "Office Politics", 7, 6,
     "tt1708695", "2878701","EP00688359","2010-11-08",
-    "http://thetvdb.com/banners/episodes/73255/2878701.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2878701.jpg"; },
   {"House", "A Pox on Our House", 7, 7,
     "tt1726380", "2878711","EP00688359","2010-11-15",
-    "http://thetvdb.com/banners/episodes/73255/2878711.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2878711.jpg"; },
   {"House", "A Pox on Our House", 7, 7,
     "tt1726380", "2878711","EP00688359","2010-11-15",
-    "http://thetvdb.com/banners/episodes/73255/2878711.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2878711.jpg"; },
   {"House", "Larger Than Life", 7, 9,
     "tt1726382", "2861961","EP00688359","2011-01-17",
-    "http://thetvdb.com/banners/episodes/73255/2861961.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2861961.jpg"; },
   {"House", "Carrot or Stick", 7, 10,
     "tt1726371", "2861951","EP00688359","2011-01-24",
-    "http://thetvdb.com/banners/episodes/73255/2861951.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/2861951.jpg"; },
   {"House", "Family Practice", 7, 11,
     "tt1726372", "3473831","EP00688359","2011-02-07",
-    "http://thetvdb.com/banners/episodes/73255/3473831.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3473831.jpg"; },
   {"House", "You Must Remember This", 7, 12,
     "tt1726373", "3553891","EP00688359","2011-02-14",
-    "http://thetvdb.com/banners/episodes/73255/3553891.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3553891.jpg"; },
   {"House", "You Must Remember This", 7, 12,
     "tt1726373", "3553891","EP00688359","2011-02-14",
-    "http://thetvdb.com/banners/episodes/73255/3553891.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3553891.jpg"; },
   {"House", "Two Stories", 7, 13,
     "tt1726374", "3565631","EP00688359","2011-02-21",
-    "http://thetvdb.com/banners/episodes/73255/3565631.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3565631.jpg"; },
   {"House", "Recession Proof", 7, 14,
     "tt1726375", "3565641","EP00688359","2011-02-28",
-    "http://thetvdb.com/banners/episodes/73255/3565641.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3565641.jpg"; },
   {"House", "Bombshells", 7, 15,
     "tt1726376", "3565651","EP00688359","2011-03-07",
-    "http://thetvdb.com/banners/episodes/73255/3565651.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3565651.jpg"; },
   {"House", "Out of the Chute", 7, 16,
     "tt1842688", "3565661","EP00688359","2011-03-14",
-    "http://thetvdb.com/banners/episodes/73255/3565661.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3565661.jpg"; },
   {"House", "Fall from Grace", 7, 17,
     "tt1842081", "3565671","EP00688359","2011-03-21",
-    "http://thetvdb.com/banners/episodes/73255/3565671.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3565671.jpg"; },
   {"House", "Fall from Grace", 7, 17,
     "tt1842081", "3565671","EP00688359","2011-03-21",
-    "http://thetvdb.com/banners/episodes/73255/3565671.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3565671.jpg"; },
   {"House", "Last Temptation", 7, 19,
     "tt1880571", "3934671","EP00688359","2011-04-18",
-    "http://thetvdb.com/banners/episodes/73255/3934671.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3934671.jpg"; },
   {"House", "Changes", 7, 20,
     "tt1883788", "3934691","EP00688359","2011-05-02",
-    "http://thetvdb.com/banners/episodes/73255/3934691.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3934691.jpg"; },
   {"House", "The Fix", 7, 21,
     "tt1902562", "3934761","EP00688359","2011-05-09",
-    "http://thetvdb.com/banners/episodes/73255/3934761.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3934761.jpg"; },
   {"House", "After Hours", 7, 22,
     "tt1900094", "3934781","EP00688359","2011-05-16",
-    "http://thetvdb.com/banners/episodes/73255/3934781.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/3934781.jpg"; },
   {"House", "Twenty Vicodin", 8, 1,
     "tt2006450", "4120406","EP00688359","2011-10-03",
-    "http://thetvdb.com/banners/episodes/73255/4120406.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4120406.jpg"; },
   {"House", "Transplant", 8, 2,
     "tt2015677", "4155773","EP00688359","2011-10-10",
-    "http://thetvdb.com/banners/episodes/73255/4155773.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4155773.jpg"; },
   {"House", "Charity Case", 8, 3,
     "tt2016511", "4155774","EP00688359","2011-10-17",
-    "http://thetvdb.com/banners/episodes/73255/4155774.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4155774.jpg"; },
   {"House", "Risky Business", 8, 4,
     "tt2021267", "4159274","EP00688359","2011-10-31",
-    "http://thetvdb.com/banners/episodes/73255/4159274.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4159274.jpg"; },
   {"House", "The Confession", 8, 5,
     "tt2063276", "4176819","EP00688359","2011-11-07",
-    "http://thetvdb.com/banners/episodes/73255/4176819.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4176819.jpg"; },
   {"House", "Parents", 8, 6,
     "tt2084392", "4190490","EP00688359","2011-11-14",
-    "http://thetvdb.com/banners/episodes/73255/4190490.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4190490.jpg"; },
   {"House", "Dead & Buried", 8, 7,
     "tt2084393", "4190489","EP00688359","2011-11-21",
-    "http://thetvdb.com/banners/episodes/73255/4190489.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4190489.jpg"; },
   {"House", "Perils of Paranoia", 8, 8,
     "tt2084394", "4190488","EP00688359","2011-11-28",
-    "http://thetvdb.com/banners/episodes/73255/4190488.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4190488.jpg"; },
   {"House", "Better Half", 8, 9,
     "tt2092629", "4195884","EP00688359","2012-01-23",
-    "http://thetvdb.com/banners/episodes/73255/4195884.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4195884.jpg"; },
   {"House", "Runaways", 8, 10,
     "tt2121953", "4217133","EP00688359","2012-01-30",
-    "http://thetvdb.com/banners/episodes/73255/4217133.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4217133.jpg"; },
   {"House", "Nobody's Fault", 8, 11,
     "tt2121954", "4217134","EP00688359","2012-02-06",
-    "http://thetvdb.com/banners/episodes/73255/4217134.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4217134.jpg"; },
   {"House", "Chase", 8, 12,
     "tt2121955", "4217135","EP00688359","2012-02-13",
-    "http://thetvdb.com/banners/episodes/73255/4217135.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4217135.jpg"; },
   {"House", "Chase", 8, 12,
     "tt2121955", "4217135","EP00688359","2012-02-13",
-    "http://thetvdb.com/banners/episodes/73255/4217135.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4217135.jpg"; },
   {"House", "Man of the House", 8, 13,
     "tt2121956", "4225825","EP00688359","2012-02-20",
-    "http://thetvdb.com/banners/episodes/73255/4225825.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4225825.jpg"; },
   {"House", "Love is Blind", 8, 14,
     "tt2121957", "4225826","EP00688359","2012-03-19",
-    "http://thetvdb.com/banners/episodes/73255/4225826.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4225826.jpg"; },
   {"House", "Blowing the Whistle", 8, 15,
     "tt2121958", "4225827","EP00688359","2012-04-02",
-    "http://thetvdb.com/banners/episodes/73255/4225827.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4225827.jpg"; },
   {"House", "Gut Check", 8, 16,
     "tt2121959", "4265763","EP00688359","2012-04-09",
-    "http://thetvdb.com/banners/episodes/73255/4265763.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4265763.jpg"; },
   {"House", "We Need the Eggs", 8, 17,
     "tt2121960", "4265764","EP00688359","2012-04-16",
-    "http://thetvdb.com/banners/episodes/73255/4265764.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4265764.jpg"; },
   {"House", "Body and Soul", 8, 18,
     "tt2121961", "4265765","EP00688359","2012-04-23",
-    "http://thetvdb.com/banners/episodes/73255/4265765.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4265765.jpg"; },
   {"House", "The C Word", 8, 19,
     "tt2121962", "4265766","EP00688359","2012-04-30",
-    "http://thetvdb.com/banners/episodes/73255/4265766.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4265766.jpg"; },
   {"House", "Post Mortem", 8, 20,
     "tt2121963", "4265767","EP00688359","2012-05-07",
-    "http://thetvdb.com/banners/episodes/73255/4265767.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4265767.jpg"; },
   {"House", "Holding On", 8, 21,
     "tt2121964", "4265768","EP00688359","2012-05-14",
-    "http://thetvdb.com/banners/episodes/73255/4265768.jpg"; },
+    "https://thetvdb.com/banners/episodes/73255/4265768.jpg"; },
   {"House", "Everybody Dies", 8, 22,
     "tt2121965", "4265769","EP00688359","2012-05-21",
-    "http://thetvdb.com/banners/episodes/73255/4265769.jpg"; }
+    "https://thetvdb.com/banners/episodes/73255/4265769.jpg"; }
 };
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]