[gnome-online-accounts/gnome-3-14] providers: Fix JsonParser leaks
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts/gnome-3-14] providers: Fix JsonParser leaks
- Date: Mon, 14 Sep 2015 13:46:26 +0000 (UTC)
commit 2d710cd56e8132c4db485dfc24c538726dc1f255
Author: Christophe Fergeau <cfergeau redhat com>
Date: Thu Jul 23 23:33:05 2015 +0200
providers: Fix JsonParser leaks
After creating a JsonParser with json_parser_new(), its memory must be
released with g_object_unref().
https://bugzilla.gnome.org/show_bug.cgi?id=752939
src/goabackend/goaflickrprovider.c | 1 +
src/goabackend/goagoogleprovider.c | 1 +
src/goabackend/goaoauth2provider.c | 1 +
src/goabackend/goawindowsliveprovider.c | 1 +
4 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/src/goabackend/goaflickrprovider.c b/src/goabackend/goaflickrprovider.c
index 5be855b..54efb3e 100644
--- a/src/goabackend/goaflickrprovider.c
+++ b/src/goabackend/goaflickrprovider.c
@@ -254,6 +254,7 @@ get_identity_sync (GoaOAuthProvider *provider,
}
out:
+ g_clear_object (&parser);
g_clear_error (&identity_error);
g_clear_object (&call);
g_clear_object (&proxy);
diff --git a/src/goabackend/goagoogleprovider.c b/src/goabackend/goagoogleprovider.c
index 8a11847..149862a 100644
--- a/src/goabackend/goagoogleprovider.c
+++ b/src/goabackend/goagoogleprovider.c
@@ -257,6 +257,7 @@ get_identity_sync (GoaOAuth2Provider *provider,
*out_presentation_identity = g_strdup (ret); /* for now: use email as presentation identity */
out:
+ g_clear_object (&parser);
g_clear_error (&identity_error);
g_clear_object (&call);
g_clear_object (&proxy);
diff --git a/src/goabackend/goaoauth2provider.c b/src/goabackend/goaoauth2provider.c
index a2cd347..11f89d0 100644
--- a/src/goabackend/goaoauth2provider.c
+++ b/src/goabackend/goaoauth2provider.c
@@ -731,6 +731,7 @@ get_tokens_sync (GoaOAuth2Provider *provider,
GOA_ERROR,
GOA_ERROR_FAILED,
_("Could not parse response"));
+ g_object_unref (parser);
goto out;
}
/* refresh_token is optional... */
diff --git a/src/goabackend/goawindowsliveprovider.c b/src/goabackend/goawindowsliveprovider.c
index 9be1f4f..f96e449 100644
--- a/src/goabackend/goawindowsliveprovider.c
+++ b/src/goabackend/goawindowsliveprovider.c
@@ -242,6 +242,7 @@ get_identity_sync (GoaOAuth2Provider *provider,
}
out:
+ g_clear_object (&parser);
g_clear_error (&identity_error);
g_clear_object (&call);
g_clear_object (&proxy);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]