[gtk+] label: Avoid recalculation in some cases
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] label: Avoid recalculation in some cases
- Date: Wed, 23 Sep 2015 11:08:20 +0000 (UTC)
commit 1bb86c2056442663caa6c69069f94f6d9d7f3d97
Author: Matthias Clasen <mclasen redhat com>
Date: Sat Sep 19 23:58:11 2015 -0400
label: Avoid recalculation in some cases
Avoid recalculation the entire label layout when nothing changed.
gtk/gtklabel.c | 32 ++++++++++++++++++++------------
1 files changed, 20 insertions(+), 12 deletions(-)
---
diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index 6a639fd..7b2775f 100644
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -412,10 +412,10 @@ static void gtk_label_set_text_internal (GtkLabel *label,
gchar *str);
static void gtk_label_set_label_internal (GtkLabel *label,
gchar *str);
-static void gtk_label_set_use_markup_internal (GtkLabel *label,
- gboolean val);
-static void gtk_label_set_use_underline_internal (GtkLabel *label,
- gboolean val);
+static gboolean gtk_label_set_use_markup_internal (GtkLabel *label,
+ gboolean val);
+static gboolean gtk_label_set_use_underline_internal (GtkLabel *label,
+ gboolean val);
static void gtk_label_set_uline_text_internal (GtkLabel *label,
const gchar *str);
static void gtk_label_set_pattern_internal (GtkLabel *label,
@@ -2129,9 +2129,9 @@ gtk_label_set_label_internal (GtkLabel *label,
g_object_notify_by_pspec (G_OBJECT (label), label_props[PROP_LABEL]);
}
-static void
+static gboolean
gtk_label_set_use_markup_internal (GtkLabel *label,
- gboolean val)
+ gboolean val)
{
GtkLabelPrivate *priv = label->priv;
@@ -2141,12 +2141,16 @@ gtk_label_set_use_markup_internal (GtkLabel *label,
priv->use_markup = val;
g_object_notify_by_pspec (G_OBJECT (label), label_props[PROP_USE_MARKUP]);
+
+ return TRUE;
}
+
+ return FALSE;
}
-static void
+static gboolean
gtk_label_set_use_underline_internal (GtkLabel *label,
- gboolean val)
+ gboolean val)
{
GtkLabelPrivate *priv = label->priv;
@@ -2156,7 +2160,11 @@ gtk_label_set_use_underline_internal (GtkLabel *label,
priv->use_underline = val;
g_object_notify_by_pspec (G_OBJECT (label), label_props[PROP_USE_UNDERLINE]);
+
+ return TRUE;
}
+
+ return FALSE;
}
/* Calculates text, attrs and mnemonic_keyval from
@@ -5947,8 +5955,8 @@ gtk_label_set_use_markup (GtkLabel *label,
g_object_freeze_notify (G_OBJECT (label));
- gtk_label_set_use_markup_internal (label, setting);
- gtk_label_recalculate (label);
+ if (gtk_label_set_use_markup_internal (label, setting))
+ gtk_label_recalculate (label);
g_object_thaw_notify (G_OBJECT (label));
}
@@ -5987,8 +5995,8 @@ gtk_label_set_use_underline (GtkLabel *label,
g_object_freeze_notify (G_OBJECT (label));
- gtk_label_set_use_underline_internal (label, setting);
- gtk_label_recalculate (label);
+ if (gtk_label_set_use_underline_internal (label, setting))
+ gtk_label_recalculate (label);
g_object_thaw_notify (G_OBJECT (label));
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]