[gnome-software] Fix possible double frees in new AsProfile code
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] Fix possible double frees in new AsProfile code
- Date: Mon, 28 Sep 2015 10:42:32 +0000 (UTC)
commit b64b403cbc90b3edf1e669d9bd39c83989dccd55
Author: Kalev Lember <klember redhat com>
Date: Mon Sep 28 09:46:56 2015 +0200
Fix possible double frees in new AsProfile code
src/plugins/gs-plugin-packagekit-refine.c | 2 +-
src/plugins/gs-plugin-packagekit-refresh.c | 2 +-
src/plugins/gs-plugin-packagekit.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/plugins/gs-plugin-packagekit-refine.c b/src/plugins/gs-plugin-packagekit-refine.c
index 6344168..612d551 100644
--- a/src/plugins/gs-plugin-packagekit-refine.c
+++ b/src/plugins/gs-plugin-packagekit-refine.c
@@ -124,7 +124,7 @@ gs_plugin_packagekit_progress_cb (PkProgress *progress,
plugin->priv->ptask = as_profile_start_literal (plugin->profile,
"packagekit-refine::transaction");
} else if (status == PK_STATUS_ENUM_FINISHED) {
- as_profile_task_free (plugin->priv->ptask);
+ g_clear_pointer (&plugin->priv->ptask, as_profile_task_free);
}
plugin_status = packagekit_status_enum_to_plugin_status (status);
diff --git a/src/plugins/gs-plugin-packagekit-refresh.c b/src/plugins/gs-plugin-packagekit-refresh.c
index b7aaf04..13f45b1 100644
--- a/src/plugins/gs-plugin-packagekit-refresh.c
+++ b/src/plugins/gs-plugin-packagekit-refresh.c
@@ -88,7 +88,7 @@ gs_plugin_packagekit_progress_cb (PkProgress *progress,
plugin->priv->ptask = as_profile_start_literal (plugin->profile,
"packagekit-refresh::transaction");
} else if (status == PK_STATUS_ENUM_FINISHED) {
- as_profile_task_free (plugin->priv->ptask);
+ g_clear_pointer (&plugin->priv->ptask, as_profile_task_free);
}
plugin_status = packagekit_status_enum_to_plugin_status (status);
diff --git a/src/plugins/gs-plugin-packagekit.c b/src/plugins/gs-plugin-packagekit.c
index efeeee7..2987882 100644
--- a/src/plugins/gs-plugin-packagekit.c
+++ b/src/plugins/gs-plugin-packagekit.c
@@ -94,7 +94,7 @@ gs_plugin_packagekit_progress_cb (PkProgress *progress,
data->ptask = as_profile_start_literal (plugin->profile,
"packagekit-refine::transaction");
} else if (status == PK_STATUS_ENUM_FINISHED) {
- as_profile_task_free (data->ptask);
+ g_clear_pointer (&data->ptask, as_profile_task_free);
}
plugin_status = packagekit_status_enum_to_plugin_status (status);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]