[libxml++] Document: Make some methods non-virtual



commit 480e92f042e86b04c748fffd884fd57d9e6247d3
Author: Kjell Ahlstedt <kjell ahlstedt bredband net>
Date:   Mon Sep 28 17:18:05 2015 +0200

    Document: Make some methods non-virtual
    
    * libxml++/document.h: Make some private methods non-virtual. Bug #754673.

 libxml++/document.h |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/libxml++/document.h b/libxml++/document.h
index a70a566..e49eda9 100644
--- a/libxml++/document.h
+++ b/libxml++/document.h
@@ -53,9 +53,7 @@ class Document : NonCopyable
   {
   public:
     Init();
-
-    //TODO: Remove the virtual when we can break ABI?
-    virtual ~Init();
+    ~Init();
   };
 
   friend class SaxParser;
@@ -253,11 +251,9 @@ protected:
   _xmlEntity* get_entity(const Glib::ustring& name);
 
 private:
-  //TODO: Remove virtuals when we can break ABI.
-
-  virtual void do_write_to_file(const Glib::ustring& filename, const Glib::ustring& encoding, bool format);
-  virtual Glib::ustring do_write_to_string(const Glib::ustring& encoding, bool format);
-  virtual void do_write_to_stream(std::ostream& output, const Glib::ustring& encoding, bool format);
+  void do_write_to_file(const Glib::ustring& filename, const Glib::ustring& encoding, bool format);
+  Glib::ustring do_write_to_string(const Glib::ustring& encoding, bool format);
+  void do_write_to_stream(std::ostream& output, const Glib::ustring& encoding, bool format);
 
   static Init init_;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]