[network-manager-openvpn] import: port is not mandatory for http proxy
- From: Lubomir Rintel <lkundrak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-openvpn] import: port is not mandatory for http proxy
- Date: Thu, 28 Apr 2016 16:12:23 +0000 (UTC)
commit 9a6936de8fe1e9bbb5daae80f9ab1c4ebdf736b5
Author: Lubomir Rintel <lkundrak v3 sk>
Date: Thu Apr 28 18:11:31 2016 +0200
import: port is not mandatory for http proxy
CID 99743 (#1 of 1): Logically dead code (DEADCODE)dead_error_line:
Execution cannot reach this statement: proxy_port = "8080";.
properties/import-export.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/properties/import-export.c b/properties/import-export.c
index d2532bc..16a5925 100644
--- a/properties/import-export.c
+++ b/properties/import-export.c
@@ -1836,7 +1836,7 @@ do_export_create (NMConnection *connection, const char *path, GError **error)
proxy_username = nm_setting_vpn_get_data_item (s_vpn, NM_OPENVPN_KEY_HTTP_PROXY_USERNAME);
proxy_password = nm_setting_vpn_get_secret (s_vpn, NM_OPENVPN_KEY_HTTP_PROXY_PASSWORD);
- if (nm_streq (proxy_type, "http") && proxy_server && proxy_port) {
+ if (nm_streq (proxy_type, "http") && proxy_server) {
char *authfile, *authcontents, *base, *dirname;
if (!proxy_port)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]