[eog/gnome-3-16] EogErrorMessageArea: Make sure error messages are valid UTF8
- From: Felix Riemann <friemann src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [eog/gnome-3-16] EogErrorMessageArea: Make sure error messages are valid UTF8
- Date: Sun, 21 Aug 2016 15:06:19 +0000 (UTC)
commit 1222dd0077de472818bacbc8dcb0ff031bed0de2
Author: Felix Riemann <friemann gnome org>
Date: Sun Aug 21 15:56:46 2016 +0200
EogErrorMessageArea: Make sure error messages are valid UTF8
GMarkup requires valid UTF8 input strings and would cause odd
looking messages if given invalid input. This could also trigger an
out-of-bounds write in glib before 2.44.1. Reported by kaslovdmitri.
https://bugzilla.gnome.org/show_bug.cgi?id=770143
src/eog-error-message-area.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/eog-error-message-area.c b/src/eog-error-message-area.c
index cdbeda7..bea5fd5 100644
--- a/src/eog-error-message-area.c
+++ b/src/eog-error-message-area.c
@@ -28,6 +28,7 @@
#include "eog-error-message-area.h"
#include "eog-image.h"
+#include "eog-util.h"
#include <glib.h>
#include <glib/gi18n.h>
@@ -171,7 +172,7 @@ eog_image_load_error_message_area_new (const gchar *caption,
error_message = g_strdup_printf (_("Could not load image '%s'."),
pango_escaped_caption);
- message_details = g_strdup (error->message);
+ message_details = eog_util_make_valid_utf8 (error->message);
message_area = create_error_message_area (error_message,
message_details,
@@ -213,7 +214,7 @@ eog_image_save_error_message_area_new (const gchar *caption,
error_message = g_strdup_printf (_("Could not save image '%s'."),
pango_escaped_caption);
- message_details = g_strdup (error->message);
+ message_details = eog_util_make_valid_utf8 (error->message);
message_area = create_error_message_area (error_message,
message_details,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]