[gparted] Stop providing a default for FileSystem::resize() fill_partition argument



commit 029a8eb19d9cc6fbd8dfa685bb5972bc58c65fb5
Author: Mike Fleetwood <mike fleetwood googlemail com>
Date:   Thu Oct 27 14:54:21 2016 +0100

    Stop providing a default for FileSystem::resize() fill_partition argument
    
    FileSystem::resize() (and derived) is only ever called from a single
    location and always with the fill_partition argument supplied [1].
    Therefore providing a default for the argument is unnecessary.  So
    remove it.
    
    [1] Since these two commits from 2006-06-17, before GParted 0.3.0, which
        added resize_filesystem() and maximize_filesystem() methods to wrap
        calls to p_filesystem->resize() into a single location:
    
        08245cd08c5e89e68ac37d1f1271ce89300d3233
        cleanups in the core and the fs'es (resize)
    
        2d7fb5700be4da994ffc9b42785d897b79e1696c
        more cleanups in the core and the fs'es (these changelogs are getting

 include/FileSystem.h |    4 ++--
 include/btrfs.h      |    2 +-
 include/ext2.h       |    2 +-
 include/jfs.h        |    2 +-
 include/linux_swap.h |    2 +-
 include/lvm2_pv.h    |    2 +-
 include/nilfs2.h     |    2 +-
 include/ntfs.h       |    2 +-
 include/reiserfs.h   |    2 +-
 include/xfs.h        |    2 +-
 10 files changed, 11 insertions(+), 11 deletions(-)
---
diff --git a/include/FileSystem.h b/include/FileSystem.h
index 80832ba..c3bc63e 100644
--- a/include/FileSystem.h
+++ b/include/FileSystem.h
@@ -69,8 +69,8 @@ public:
        virtual bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) { return 
false; };
        virtual bool create( const Partition & new_partition, OperationDetail & operationdetail ) { return 
false; };
        virtual bool resize( const Partition & partition_new,
-                            OperationDetail & operationdetail,
-                            bool fill_partition = false ) { return false; };
+                            OperationDetail & operationdetail,
+                            bool fill_partition ) { return false; };
        virtual bool move( const Partition & partition_new
                         , const Partition & partition_old
                         , OperationDetail & operationdetail
diff --git a/include/btrfs.h b/include/btrfs.h
index 619f8cf..491ca8a 100644
--- a/include/btrfs.h
+++ b/include/btrfs.h
@@ -43,7 +43,7 @@ public:
        void read_uuid( Partition & partition ) ;
        bool write_uuid( const Partition & partition, OperationDetail & operationdetail );
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
        bool check_repair( const Partition & partition, OperationDetail & operationdetail ) ;
 
        static void clear_cache() ;
diff --git a/include/ext2.h b/include/ext2.h
index fc0a39a..7a5e00b 100644
--- a/include/ext2.h
+++ b/include/ext2.h
@@ -50,7 +50,7 @@ public:
        void read_uuid( Partition & partition ) ;
        bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) ;
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
        bool check_repair( const Partition & partition, OperationDetail & operationdetail ) ;
        bool move( const Partition & partition_new,
                   const Partition & partition_old,
diff --git a/include/jfs.h b/include/jfs.h
index b0cfa86..089049f 100644
--- a/include/jfs.h
+++ b/include/jfs.h
@@ -35,7 +35,7 @@ public:
        void read_uuid( Partition & partition ) ;
        bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) ;
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
        bool check_repair( const Partition & partition, OperationDetail & operationdetail ) ;
 };
 
diff --git a/include/linux_swap.h b/include/linux_swap.h
index cdf1c09..b856495 100644
--- a/include/linux_swap.h
+++ b/include/linux_swap.h
@@ -37,7 +37,7 @@ public:
        void read_uuid( Partition & partition ) ;
        bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) ;
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
        bool move( const Partition & partition_new
                 , const Partition & partition_old
                 , OperationDetail & operationdetail
diff --git a/include/lvm2_pv.h b/include/lvm2_pv.h
index 1a850ef..0f47157 100644
--- a/include/lvm2_pv.h
+++ b/include/lvm2_pv.h
@@ -32,7 +32,7 @@ public:
        bool is_busy( const Glib::ustring & path ) ;
        void set_used_sectors( Partition & partition ) ;
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
        bool check_repair( const Partition & partition, OperationDetail & operationdetail ) ;
        bool remove( const Partition & partition, OperationDetail & operationdetail ) ;
 };
diff --git a/include/nilfs2.h b/include/nilfs2.h
index c90f8bb..7e85b4e 100644
--- a/include/nilfs2.h
+++ b/include/nilfs2.h
@@ -34,7 +34,7 @@ public:
        void read_uuid( Partition & partition ) ;
        bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) ;
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
 };
 
 } //GParted
diff --git a/include/ntfs.h b/include/ntfs.h
index 660480b..1285aa9 100644
--- a/include/ntfs.h
+++ b/include/ntfs.h
@@ -36,7 +36,7 @@ public:
        void read_uuid( Partition & partition ) ;
        bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) ;
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
        bool copy( const Partition & src_part, 
                   Partition & dest_part,
                   OperationDetail & operationdetail ) ;
diff --git a/include/reiserfs.h b/include/reiserfs.h
index aadb114..888710e 100644
--- a/include/reiserfs.h
+++ b/include/reiserfs.h
@@ -35,7 +35,7 @@ public:
        void read_uuid( Partition & partition ) ;
        bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) ;
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
        bool check_repair( const Partition & partition, OperationDetail & operationdetail ) ;
 };
 
diff --git a/include/xfs.h b/include/xfs.h
index 4ae0f67..b980370 100644
--- a/include/xfs.h
+++ b/include/xfs.h
@@ -39,7 +39,7 @@ public:
        void read_uuid( Partition & partition ) ;
        bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) ;
        bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
-       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
= false ) ;
+       bool resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition 
);
        bool copy( const Partition & src_part,
                   Partition & dest_part,
                   OperationDetail & operationdetail ) ;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]