[gnome-software] packagekit: Fix refining update details
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] packagekit: Fix refining update details
- Date: Thu, 15 Dec 2016 08:36:40 +0000 (UTC)
commit 35a3d96907ada3dc7ca32527051729beb6b9f6a4
Author: Kalev Lember <klember redhat com>
Date: Thu Dec 15 09:36:01 2016 +0100
packagekit: Fix refining update details
This makes the update notes correctly show up on the updates page again.
Note that this wasn't doing an array out of bounds write, even though it
looks like that at first glance: the memory allocated for the array was
always one element larger to accomodate the trailing nul and only this
got overwritten.
https://bugzilla.gnome.org/show_bug.cgi?id=775884
src/plugins/gs-plugin-packagekit-refine.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/plugins/gs-plugin-packagekit-refine.c b/src/plugins/gs-plugin-packagekit-refine.c
index 86a51ff..341a154 100644
--- a/src/plugins/gs-plugin-packagekit-refine.c
+++ b/src/plugins/gs-plugin-packagekit-refine.c
@@ -379,7 +379,7 @@ gs_plugin_packagekit_refine_updatedetails (GsPlugin *plugin,
for (i = 0; i < gs_app_list_length (list); i++) {
app = gs_app_list_index (list, i);
package_id = gs_app_get_source_id_default (app);
- package_ids[i++] = package_id;
+ package_ids[i] = package_id;
}
data.app = NULL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]