[gnome-builder] build-tools: use enum for column indexes
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] build-tools: use enum for column indexes
- Date: Sat, 31 Dec 2016 03:29:32 +0000 (UTC)
commit 5d74071273bea50fe1e41139a5c98c74c9a87cfc
Author: Christian Hergert <chergert redhat com>
Date: Fri Dec 30 19:28:18 2016 -0800
build-tools: use enum for column indexes
This makes things a bit more readable so any sort of errors are more
obvious.
plugins/build-tools/gbp-build-panel.c | 19 +++++++++++++++----
1 files changed, 15 insertions(+), 4 deletions(-)
---
diff --git a/plugins/build-tools/gbp-build-panel.c b/plugins/build-tools/gbp-build-panel.c
index ba22ce4..fe160ae 100644
--- a/plugins/build-tools/gbp-build-panel.c
+++ b/plugins/build-tools/gbp-build-panel.c
@@ -56,6 +56,12 @@ enum {
LAST_PROP
};
+enum {
+ COLUMN_DIAGNOSTIC,
+ COLUMN_TEXT,
+ LAST_COLUMN
+};
+
static GParamSpec *properties [LAST_PROP];
static void
@@ -112,7 +118,9 @@ gbp_build_panel_diagnostic (GbpBuildPanel *self,
middle = (left + right) / 2;
gtk_tree_model_iter_nth_child (model, &iter, NULL, middle);
- gtk_tree_model_get (model, &iter, 0, &item, -1);
+ gtk_tree_model_get (model, &iter,
+ COLUMN_DIAGNOSTIC, &item,
+ -1);
cmpval = ide_diagnostic_compare (item, diagnostic);
@@ -132,8 +140,8 @@ gbp_build_panel_diagnostic (GbpBuildPanel *self,
gtk_list_store_insert (self->diagnostics_store, &iter, middle);
gtk_list_store_set (self->diagnostics_store, &iter,
- 0, diagnostic,
- 1, ide_diagnostic_get_text (diagnostic),
+ COLUMN_DIAGNOSTIC, diagnostic,
+ COLUMN_TEXT, ide_diagnostic_get_text (diagnostic),
-1);
}
@@ -270,7 +278,10 @@ gbp_build_panel_diagnostic_activated (GbpBuildPanel *self,
if (!gtk_tree_model_get_iter (model, &iter, path))
IDE_EXIT;
- gtk_tree_model_get (model, &iter, 0, &diagnostic, -1);
+ gtk_tree_model_get (model, &iter,
+ COLUMN_DIAGNOSTIC, &diagnostic,
+ -1);
+
if (diagnostic == NULL)
IDE_EXIT;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]