[geocode-glib] reverse, forward: plug memleaks when _geocode_glib_cache_path_for_query() is used
- From: Aleksander Morgado <aleksm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [geocode-glib] reverse, forward: plug memleaks when _geocode_glib_cache_path_for_query() is used
- Date: Mon, 22 Feb 2016 18:03:53 +0000 (UTC)
commit 89b0175e602751cd73fcc95a128a5c7141fdc0da
Author: Aleksander Morgado <aleksander morgado collabora co uk>
Date: Mon Feb 22 11:57:46 2016 +0100
reverse,forward: plug memleaks when _geocode_glib_cache_path_for_query() is used
E.g. for the reverse geocoding operation:
==3365== 128 bytes in 1 blocks are definitely lost in loss record 2,226 of 2,357
==3365== at 0x4C2AB5D: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==3365== by 0x566A3E7: g_realloc (in /usr/lib/libglib-2.0.so.0.4600.2)
==3365== by 0x5685846: ??? (in /usr/lib/libglib-2.0.so.0.4600.2)
==3365== by 0x5685B66: g_string_insert_len (in /usr/lib/libglib-2.0.so.0.4600.2)
==3365== by 0x5650E77: ??? (in /usr/lib/libglib-2.0.so.0.4600.2)
==3365== by 0x5652214: g_build_filename (in /usr/lib/libglib-2.0.so.0.4600.2)
==3365== by 0x4E40AA0: _geocode_glib_cache_path_for_query (geocode-glib.c:92)
==3365== by 0x4E4052F: geocode_reverse_resolve_async (geocode-reverse.c:454)
==3365== by 0x400D55: main (in /home/aleksander/Development/clients/collabora/geocode-test)
https://bugzilla.gnome.org/show_bug.cgi?id=762435
geocode-glib/geocode-forward.c | 1 +
geocode-glib/geocode-reverse.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/geocode-glib/geocode-forward.c b/geocode-glib/geocode-forward.c
index f931940..5939afe 100644
--- a/geocode-glib/geocode-forward.c
+++ b/geocode-glib/geocode-forward.c
@@ -566,6 +566,7 @@ geocode_forward_search_async (GeocodeForward *forward,
on_cache_data_loaded,
simple);
g_object_unref (cache);
+ g_free (cache_path);
}
}
diff --git a/geocode-glib/geocode-reverse.c b/geocode-glib/geocode-reverse.c
index b78c381..7e70acc 100644
--- a/geocode-glib/geocode-reverse.c
+++ b/geocode-glib/geocode-reverse.c
@@ -467,6 +467,7 @@ geocode_reverse_resolve_async (GeocodeReverse *object,
on_cache_data_loaded,
simple);
g_object_unref (cache);
+ g_free (cache_path);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]