[network-manager-openvpn/th/ovpn-import-bgo761285: 7/12] properties: remove g_warning() during do_export()



commit b2a74c1e63a8761927adebb9e5ba6cdbf558d622
Author: Thomas Haller <thaller redhat com>
Date:   Thu Jan 28 23:32:35 2016 +0100

    properties: remove g_warning() during do_export()
    
    Printing a warning is not a good way to report an error to the
    user from the plugin. Either come up with a proper warning/error-reporting
    mechanism, or just silently proceed.
    
    Indeed, we have not strong verification for VPN connections, thus
    invalid connections are to be expected and the plugin should handle
    them best-effort without nagging.

 properties/import-export.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/properties/import-export.c b/properties/import-export.c
index 578fb99..2bf3a2c 100644
--- a/properties/import-export.c
+++ b/properties/import-export.c
@@ -1503,8 +1503,7 @@ do_export (const char *path, NMConnection *connection, GError **error)
                                 static_key,
                                 static_key_direction ? " " : "",
                                 static_key_direction ? static_key_direction : "");
-               } else
-                       g_warning ("%s: invalid openvpn static key configuration (missing static key)", 
__func__);
+               }
        }
 
        if (reneg_exists)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]