[pan2] Fix errors found by valgrind: 48 bytes in 1 blocks are definitely lost in loss record 7, 180 of 11, 89
- From: Petr Kovář <pmkovar src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pan2] Fix errors found by valgrind: 48 bytes in 1 blocks are definitely lost in loss record 7, 180 of 11, 89
- Date: Mon, 18 Jul 2016 16:24:23 +0000 (UTC)
commit 3de214eba61d803533ad21f4dbc0395968390453
Author: Olaf Seibert <rhialto falu nl>
Date: Tue Mar 22 01:13:14 2016 +0100
Fix errors found by valgrind: 48 bytes in 1 blocks are definitely lost in loss record 7,180 of 11,894
Looks like leaks in work-in-progress.
at 0x4C2BBCF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x6D2F578: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2)
by 0x6D46762: g_slice_alloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2)
by 0x6D46DFD: g_slice_alloc0 (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2)
by 0x6AC0371: g_type_create_instance (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
by 0x6AA238A: g_object_new_internal (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
by 0x6AA3C70: g_object_newv (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
by 0x47FB74: GPGDecErr (gpg.h:93)
by 0x47FB74: pan::BodyPane::BodyPane(pan::Data&, pan::ArticleCache&, pan::Prefs&, pan::GroupPrefs&,
pan::Queue&, pan::HeaderPane*) (body-pane.cc:1722)
by 0x4652E9: pan::GUI::GUI(pan::Data&, pan::Queue&, pan::Prefs&, pan::GroupPrefs&) (gui.cc:250)
by 0x475EA6: main (pan.cc:1098)
and
48 bytes in 1 blocks are definitely lost in loss record 7,277 of 12,136
at 0x4C2BBCF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x6D2F578: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2)
by 0x6D46762: g_slice_alloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2)
by 0x6D46DFD: g_slice_alloc0 (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2)
by 0x6AC0371: g_type_create_instance (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
by 0x6AA238A: g_object_new_internal (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
by 0x6AA3C70: g_object_newv (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
by 0x463AC2: GPGDecErr (gpg.h:93)
by 0x463AC2: pan::GUI::root_realized_cb(_GtkWidget*, void*) (gui.cc:205)
by 0x6A9D014: g_closure_invoke (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
by 0x6AAF060: signal_emit_unlocked_R (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
by 0x6AB7DFB: g_signal_emit_valist (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2)
...
by 0x52906B5: gtk_widget_show (in /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0.2400.28)
by 0x476399: run_pan_in_window (pan.cc:530)
=
pan/usenet-utils/gpg.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/pan/usenet-utils/gpg.h b/pan/usenet-utils/gpg.h
index 01c6634..88a6b17 100644
--- a/pan/usenet-utils/gpg.h
+++ b/pan/usenet-utils/gpg.h
@@ -86,8 +86,8 @@ namespace pan
{
if (err) g_error_free(err);
err = NULL;
-// if (decrypted) g_object_unref(decrypted) ;
-// if (result) g_object_unref(result);
+ if (decrypted) g_object_unref(decrypted) ;
+ if (result) g_object_unref(result);
}
GPGDecErr() : err(NULL), no_sigs(true), type(GPG_DECODE), decrypted(NULL),
result(g_mime_decrypt_result_new()) {}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]