[polari/wip/fmuellner/combined-gsoc: 99/137] chatView: Use some bits into the UserPopover template



commit f0e58ea9c5179c645028c671fc973f6345dccbfd
Author: Florian Müllner <fmuellner gnome org>
Date:   Tue Jul 19 23:56:37 2016 +0200

    chatView: Use some bits into the UserPopover template
    
    Margin and width-request aren't really specific to the chat view,
    so let's just include those in the .ui file ...

 data/resources/user-popover.ui |    2 ++
 src/chatView.js                |    4 +---
 2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/data/resources/user-popover.ui b/data/resources/user-popover.ui
index 78b949c..9fd64ca 100644
--- a/data/resources/user-popover.ui
+++ b/data/resources/user-popover.ui
@@ -2,6 +2,8 @@
 <interface>
   <template class="Gjs_UserPopover" parent="GtkPopover">
     <property name="hexpand">False</property>
+    <property name="margin">0</property><!-- isn't this the default? -->
+    <property name="width-request">280</property>
     <child>
       <object class="GtkBox">
         <property name="orientation">vertical</property>
diff --git a/src/chatView.js b/src/chatView.js
index 8330f4d..f770dfc 100644
--- a/src/chatView.js
+++ b/src/chatView.js
@@ -1314,10 +1314,8 @@ const ChatView = new Lang.Class({
 
         if (!tag._popover)
             tag._popover = new UserList.UserPopover({ relative_to: this._view,
-                                                      margin: 0,
-                                                      room: this._room,
                                                       userTracker: this._userTracker,
-                                                      width_request: 280 });
+                                                      room: this._room });
 
         tag._popover.nickname = actualNickName;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]